-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Torii-core): Handle entity deletion events #1439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recursive model deletion looking good, just some minor comments on testing
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 69.40% 69.45% +0.04%
==========================================
Files 228 229 +1
Lines 22138 22203 +65
==========================================
+ Hits 15364 15420 +56
- Misses 6774 6783 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more debug print remove and it LGTM
StoreDelRecord
events that are generated from the world.StoreDelRecordProcessor
Closes #1349
@broody