Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sozo-migrate): de-debug error formatting #1454

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 18, 2024

The Debug output isn't helpful at all.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (d74c4df) 69.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
- Coverage   70.06%   69.47%   -0.59%     
==========================================
  Files         236      236              
  Lines       22531    22555      +24     
==========================================
- Hits        15786    15670     -116     
- Misses       6745     6885     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently, there is some data missing to be printed out
by starknet-rs. ContractError reason for instance is never printed.
The idea here is to have a bit more context with sozo if a user
is stuck during migration.
This commit starts work for the dojoengine#1409 issue to add more logging
to sozo.
@glihm
Copy link
Collaborator

glihm commented Jan 18, 2024

The Debug output isn't helpful at all.

Thanks for pointing that out.

For starknet related call, we would need the debug printing, pushed some commits to move the debug print into a verbose print of scarb ui.

This will gives us more context to help devs debugging the migration by asking them running:

sozo migrate --verbose

This goes into contributions to move forward toward the issue #1409.

@glihm glihm merged commit 32a3c76 into dojoengine:main Jan 25, 2024
10 of 12 checks passed
@kariy kariy deleted the sozo-error branch January 26, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants