Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move binary crates into a dedicated dir #1471

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 22, 2024

Moved binary crates into a bin/ dir at the top level. I think we can refactor the sozo crate more as we have some other crates that depends on it.

.
├── bin/
│   ├── dojo-language-server
│   ├── katana
│   ├── sozo
│   └── torii
└── crates/
    └── ..

@kariy
Copy link
Member Author

kariy commented Jan 22, 2024

what do you guys think about this new structure ? @lambda-0x @glihm @tarrencev @broody @Larkooo ?

@tarrencev
Copy link
Contributor

tarrencev commented Jan 22, 2024

i like it. it feels like sozo should be refactored into some smaller crates though

@Larkooo
Copy link
Collaborator

Larkooo commented Jan 22, 2024

what do you guys think about this new structure ? @lambda-0x @glihm @tarrencev @broody @Larkooo ?

I think that's great, especially for torii, if we get to separate the backends like grpc, libp2p, graphql.. from the CLI binary itself. Would make it easier to work it. Same thing goes for the other crates (like maybe sozo?) that depend on some other stuff

@kariy
Copy link
Member Author

kariy commented Jan 22, 2024

it feels like sozo should be refactored into some smaller crates though

Very much agree. I think the ops stuff in sozo can be refactored into pure functions that returns simple output, independent of the CLI. Which would also make testing much easier!

@glihm
Copy link
Collaborator

glihm commented Jan 23, 2024

it feels like sozo should be refactored into some smaller crates though

Very much agree. I think the ops stuff in sozo can be refactored into pure functions that returns simple output, independent of the CLI. Which would also make testing much easier!

Definitely yes.
Can be a good next issue / PR to tackle @lambda-0x.

@kariy kariy merged commit 3620d72 into dojoengine:main Jan 23, 2024
10 checks passed
@kariy kariy deleted the workspace-refactor branch January 23, 2024 07:54
@lambda-0x
Copy link
Collaborator

Can be a good next issue / PR to tackle

currently working on manifest refactor, will keep this in mind for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants