Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana): init interval block producer with updated block env #1477

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 25, 2024

The issue was that the pending block (when using interval block producer) was being initialized with previous block environment, making the pending block to have the latest block number (block number of a block that has been canonicalized) when it should've had latest block number + 1.

Though this is an entirely separate issue from #1475, but they corrupt each other.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7527fcd) 69.40% compared to head (9419571) 69.51%.

Files Patch % Lines
crates/katana/core/src/sequencer.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   69.40%   69.51%   +0.11%     
==========================================
  Files         228      228              
  Lines       22138    22158      +20     
==========================================
+ Hits        15364    15403      +39     
+ Misses       6774     6755      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev tarrencev merged commit 1cf9caf into dojoengine:main Jan 25, 2024
12 checks passed
@kariy kariy deleted the katana-interval-producer-fix-init branch January 25, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants