Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove codecov on main merge #1480

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Jan 25, 2024

Currently, codecov reports are not always in adequation with the code being pushed in a PR.
Disabling on main merge, ensures that maintainers can evaluate a PR to be mergeable, even if the codecov report is not valid, without impacting the CI on the main branch.

Currently, codecov reports are not always in adequation with the
code being pushed in a PR.
Disabling on main merge, ensure that maintainers can evaluate
a PR to be mergeable, even if the codecov report is not valid.
@glihm glihm marked this pull request as ready for review January 25, 2024 18:05
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68e2199) 70.06% compared to head (844ad19) 70.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files         236      236           
  Lines       22531    22531           
=======================================
  Hits        15786    15786           
  Misses       6745     6745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm requested a review from tarrencev January 25, 2024 18:15
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tarrencev tarrencev merged commit a8258be into dojoengine:main Jan 25, 2024
12 checks passed
@glihm glihm deleted the ci/codecov branch February 17, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants