Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torii fix extra url parse #1506

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Torii fix extra url parse #1506

merged 1 commit into from
Feb 1, 2024

Conversation

broody
Copy link
Collaborator

@broody broody commented Feb 1, 2024

No description provided.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 369 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (b46c211) 69.82%.
Report is 16 commits behind head on main.

Files Patch % Lines
bin/katana/src/main.rs 0.00% 94 Missing ⚠️
crates/katana/runner/src/logs.rs 10.00% 72 Missing ⚠️
crates/katana/primitives/src/genesis/mod.rs 92.71% 33 Missing ⚠️
crates/katana/runner/src/prefunded.rs 0.00% 31 Missing ⚠️
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
crates/katana/runner/runner-macro/src/lib.rs 58.18% 23 Missing ⚠️
crates/katana/primitives/src/genesis/json.rs 96.25% 21 Missing ⚠️
crates/katana/primitives/src/genesis/allocation.rs 90.83% 12 Missing ⚠️
crates/katana/core/src/backend/mod.rs 28.57% 10 Missing ⚠️
crates/katana/rpc/rpc-types/src/account.rs 0.00% 10 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   70.06%   69.82%   -0.24%     
==========================================
  Files         236      257      +21     
  Lines       22531    24450    +1919     
==========================================
+ Hits        15786    17072    +1286     
- Misses       6745     7378     +633     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev tarrencev merged commit 1e29ec3 into main Feb 1, 2024
11 of 12 checks passed
@tarrencev tarrencev deleted the torii-fix-rpc branch February 1, 2024 18:33
@tarrencev
Copy link
Contributor

ah my bad. we should add a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants