Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torii bind default addr to 0.0.0.0 #1509

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Torii bind default addr to 0.0.0.0 #1509

merged 1 commit into from
Feb 1, 2024

Conversation

broody
Copy link
Collaborator

@broody broody commented Feb 1, 2024

Otherwise default service addr is 127.0.0.1:8080 and cloud hosted torii's will have to explicitly override this.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it makes it consistent with Katana. 👍

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 586 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (ccc0cc4) 69.82%.
Report is 19 commits behind head on main.

Files Patch % Lines
bin/katana/src/main.rs 0.00% 94 Missing ⚠️
crates/katana/runner/src/logs.rs 10.00% 72 Missing ⚠️
bin/saya/src/main.rs 0.00% 56 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 50 Missing ⚠️
bin/saya/src/args/mod.rs 0.00% 33 Missing ⚠️
crates/katana/primitives/src/genesis/mod.rs 92.71% 33 Missing ⚠️
...es/saya/core/src/data_availability/celestia/mod.rs 0.00% 33 Missing ⚠️
crates/katana/runner/src/prefunded.rs 0.00% 31 Missing ⚠️
bin/saya/src/args/data_availability.rs 0.00% 24 Missing ⚠️
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   70.06%   69.82%   -0.24%     
==========================================
  Files         236      257      +21     
  Lines       22531    24450    +1919     
==========================================
+ Hits        15786    17072    +1286     
- Misses       6745     7378     +633     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broody broody merged commit 1af041c into main Feb 1, 2024
11 of 12 checks passed
@broody broody deleted the bind-addr branch February 1, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants