Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(katana-db): include module in table path #1521

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Feb 7, 2024

just for clarity

@kariy kariy changed the title style(katana-db): include module in table names style(katana-db): include module in table path Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 600 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (e9a0b43) 70.55%.
Report is 25 commits behind head on main.

Files Patch % Lines
bin/katana/src/main.rs 0.00% 94 Missing ⚠️
crates/katana/runner/src/logs.rs 10.00% 72 Missing ⚠️
bin/saya/src/main.rs 0.00% 56 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 50 Missing ⚠️
crates/katana/primitives/src/genesis/mod.rs 92.40% 35 Missing ⚠️
bin/saya/src/args/mod.rs 0.00% 33 Missing ⚠️
...es/saya/core/src/data_availability/celestia/mod.rs 0.00% 33 Missing ⚠️
crates/katana/runner/src/prefunded.rs 0.00% 31 Missing ⚠️
bin/saya/src/args/data_availability.rs 0.00% 24 Missing ⚠️
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
+ Coverage   70.06%   70.55%   +0.48%     
==========================================
  Files         236      257      +21     
  Lines       22531    24881    +2350     
==========================================
+ Hits        15786    17554    +1768     
- Misses       6745     7327     +582     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit e2d5601 into dojoengine:main Feb 7, 2024
12 checks passed
@kariy kariy deleted the katana-styl branch February 7, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant