Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana-core): crate can't be build without any feature #1527

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Feb 8, 2024

Currently, compiling katana-core will fail if the messaging feature is not enabled because we're using the ethers outside of the feature's scope. We would want to allow using katana-core as is without any features enabled. This issue means that downstream crates that rely on katana-core would have to enable this feature even if they don't need it.

Use the primitive-types where the U256 is being exported from, instead of relying on ethers, for usage outside of the messaging feature scope.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 618 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (70dc1de) 70.59%.
Report is 30 commits behind head on main.

Files Patch % Lines
bin/katana/src/main.rs 0.00% 94 Missing ⚠️
crates/katana/runner/src/logs.rs 10.00% 72 Missing ⚠️
bin/saya/src/main.rs 0.00% 56 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 50 Missing ⚠️
crates/katana/primitives/src/genesis/mod.rs 92.40% 35 Missing ⚠️
bin/saya/src/args/mod.rs 0.00% 33 Missing ⚠️
...es/saya/core/src/data_availability/celestia/mod.rs 0.00% 33 Missing ⚠️
crates/katana/runner/src/prefunded.rs 0.00% 31 Missing ⚠️
bin/saya/src/args/data_availability.rs 0.00% 24 Missing ⚠️
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1527      +/-   ##
==========================================
+ Coverage   70.06%   70.59%   +0.53%     
==========================================
  Files         236      257      +21     
  Lines       22531    24975    +2444     
==========================================
+ Hits        15786    17632    +1846     
- Misses       6745     7343     +598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy changed the title katana-core: use the crate where the types are exported from fix(katana-core): crate can't be build without any feature Feb 8, 2024
@kariy kariy merged commit c839363 into dojoengine:main Feb 8, 2024
12 checks passed
@kariy kariy deleted the num-bigint branch February 8, 2024 23:01
kariy added a commit that referenced this pull request Apr 1, 2024
…1746)

before this, running cargo test -p katana-core would result in error bcs we're using ethers crate in non-feature code

ref #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants