fix(katana-core): crate can't be build without any feature #1527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compiling
katana-core
will fail if themessaging
feature is not enabled because we're using theethers
outside of the feature's scope. We would want to allow usingkatana-core
as is without any features enabled. This issue means that downstream crates that rely onkatana-core
would have to enable this feature even if they don't need it.Use the
primitive-types
where theU256
is being exported from, instead of relying onethers
, for usage outside of themessaging
feature scope.