Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sozo): propose multicall format for sozo auth writer #1555

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Feb 19, 2024

Auth initialization can be a very long step on public network. Having multicall support here can help.

I'm not sure if the proposed format in this PR is the most appropriate, but it's easy to script:

sozo auth writer model1,0x1234 model2,01234 model2,0x111

Open to any other suggestion!

@glihm glihm changed the title feat: propose multicall format for auth writer feat(sozo): propose multicall format for sozo auth writer Feb 19, 2024
@glihm glihm marked this pull request as draft February 19, 2024 05:31
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (1ffcc16) 70.47%.
Report is 42 commits behind head on main.

Files Patch % Lines
bin/sozo/src/ops/auth.rs 0.00% 17 Missing ⚠️
bin/sozo/src/commands/auth.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   70.06%   70.47%   +0.41%     
==========================================
  Files         236      261      +25     
  Lines       22531    25315    +2784     
==========================================
+ Hits        15786    17841    +2055     
- Misses       6745     7474     +729     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm marked this pull request as ready for review February 19, 2024 05:40
@tarrencev tarrencev merged commit 716520e into dojoengine:main Feb 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants