Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show world explore url when starting Torii #1565

Merged

Conversation

JunichiSugiura
Copy link
Contributor

@JunichiSugiura JunichiSugiura commented Feb 19, 2024

Show https://worlds.dev/torii?url=<url-encoded> when starting Torii.

@JunichiSugiura JunichiSugiura marked this pull request as draft February 19, 2024 17:40
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (401c930) 70.79% compared to head (75bb654) 70.66%.
Report is 1 commits behind head on main.

Files Patch % Lines
bin/torii/src/main.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
- Coverage   70.79%   70.66%   -0.13%     
==========================================
  Files         264      264              
  Lines       25574    25623      +49     
==========================================
+ Hits        18104    18107       +3     
- Misses       7470     7516      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bin/torii/src/main.rs Outdated Show resolved Hide resolved
@JunichiSugiura JunichiSugiura force-pushed the feat(torii)/world-explorer-endpoint branch 3 times, most recently from 3ced3cf to b38e8d8 Compare February 20, 2024 12:04
@JunichiSugiura JunichiSugiura marked this pull request as ready for review February 20, 2024 19:08
@JunichiSugiura JunichiSugiura force-pushed the feat(torii)/world-explorer-endpoint branch 2 times, most recently from f02ee97 to c0cd511 Compare February 21, 2024 13:32
bin/torii/src/main.rs Outdated Show resolved Hide resolved
@tarrencev tarrencev merged commit f521686 into dojoengine:main Feb 22, 2024
11 of 12 checks passed
@JunichiSugiura JunichiSugiura deleted the feat(torii)/world-explorer-endpoint branch February 24, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants