Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to declare standard ArgentX account contract classes #1579

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Feb 25, 2024

Relies on #1610

Related to #1328

Add a declare script using starkli for declaring standard ArgentX account contract, both 0.3.0 and 0.3.1 are supported.

Usage

Go to the /scripts directory:

cd crates/katana/scripts

Run the script

Note: The script must be run inside the /scripts dir as the file path is relative to it

./declare-argent-account.sh <ACCOUNT_ADDRESS> <PRIVATE_KEY> <RPC_URL>

The command above will declare both 0.3.0 and 0.3.1 Argent account classes. If you want to declare a specific version, you can specify the exact class hash of the Argent account class:

./declare-argent-account.sh 0x1 0x2 http://localhost:5050 0x01a736d6ed154502257f02b1ccdf4d9d1089f80811cd6acad48e6b6a9d1f2003

0.3.0

0x01a736d6ed154502257f02b1ccdf4d9d1089f80811cd6acad48e6b6a9d1f2003 (0.3.0)

https://github.com/argentlabs/argent-contracts-starknet/blob/account-0.3.0/contracts/account/src/argent_account.cairo

https://voyager.online/class/0x01a736d6ed154502257f02b1ccdf4d9d1089f80811cd6acad48e6b6a9d1f2003

0.3.1

0x29927c8af6bccf3f6fda035981e765a7bdbf18a2dc0d630494f8758aa908e2b (0.3.1)

https://github.com/argentlabs/argent-contracts-starknet/blob/account-0.3.1/src/account/argent_account.cairo

https://voyager.online/class/0x29927c8af6bccf3f6fda035981e765a7bdbf18a2dc0d630494f8758aa908e2b

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (9b2bf3e) to head (2f42e23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   69.72%   69.71%   -0.01%     
==========================================
  Files         265      265              
  Lines       26750    26756       +6     
==========================================
+ Hits        18651    18653       +2     
- Misses       8099     8103       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponderingdemocritus
Copy link
Contributor

Looks good - we should also do the braavos one

@kariy kariy changed the title Add a script to declare standard ArgentX account contract class Add a script to declare standard ArgentX account contract classes Mar 5, 2024
@kariy kariy merged commit 70c32b2 into main Mar 5, 2024
11 of 12 checks passed
@kariy kariy deleted the argent-script branch March 5, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants