Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction_hash and block_number in the manifest file #1651

Merged
merged 4 commits into from
Mar 14, 2024

fix fmt issues

5ab6300
Select commit
Loading
Failed to load commit list.
Merged

feat: add transaction_hash and block_number in the manifest file #1651

fix fmt issues
5ab6300
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 13, 2024 in 1s

69.53% (-0.02%) compared to fdaf0ac

View this Pull Request on Codecov

69.53% (-0.02%) compared to fdaf0ac

Details

Codecov Report

Attention: Patch coverage is 45.88235% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 69.53%. Comparing base (fdaf0ac) to head (5ab6300).
Report is 4 commits behind head on main.

Files Patch % Lines
bin/sozo/src/ops/migration/mod.rs 29.78% 33 Missing ⚠️
bin/sozo/src/commands/dev.rs 0.00% 6 Missing ⚠️
crates/dojo-world/src/manifest.rs 77.77% 4 Missing ⚠️
crates/dojo-world/src/migration/mod.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   69.55%   69.53%   -0.02%     
==========================================
  Files         266      266              
  Lines       27213    27267      +54     
==========================================
+ Hits        18927    18960      +33     
- Misses       8286     8307      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.