-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from ethers to alloy types #1693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @tcoratger for this update!
Some minor comments and one question:
Why a specific rev is used? At the moment it still recommended to use git rev instead of crates.io
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 67.77% 67.85% +0.08%
==========================================
Files 304 304
Lines 33109 33161 +52
==========================================
+ Hits 22438 22502 +64
+ Misses 10671 10659 -12 ☔ View full report in Codecov by Sentry. |
The saya test was a bit flaky, it's fixed on main once #1710 is merged. |
c0e5118
to
27d18c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. Seems to me alloy-primitives
is used in many crates, maybe it's better to have it on workspace level.
f7d11fe
to
f41e55f
Compare
This PR handles the migration from ethers to alloy types.
Should close #1681.
Related to DOJ-277.