Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from ethers to alloy types #1693

Merged
merged 20 commits into from
Apr 3, 2024
Merged

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Mar 23, 2024

This PR handles the migration from ethers to alloy types.

Should close #1681.
Related to DOJ-277.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @tcoratger for this update!
Some minor comments and one question:

Why a specific rev is used? At the moment it still recommended to use git rev instead of crates.io?

crates/katana/core/src/service/messaging/ethereum.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@glihm glihm added katana This issue is related to Katana saya This issue is related to Saya (settlement) external-contributor labels Mar 25, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 67.85%. Comparing base (f9b8c02) to head (fcb81b7).
Report is 2 commits behind head on main.

Files Patch % Lines
...ates/katana/core/src/service/messaging/ethereum.rs 42.02% 40 Missing ⚠️
crates/saya/core/src/prover/serializer.rs 0.00% 5 Missing ⚠️
crates/katana/core/src/service/messaging/mod.rs 0.00% 1 Missing ⚠️
crates/katana/rpc/rpc-types/src/receipt.rs 0.00% 1 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 1 Missing ⚠️
crates/saya/core/src/prover/state_diff.rs 0.00% 1 Missing ⚠️
crates/saya/core/src/prover/vec252.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   67.77%   67.85%   +0.08%     
==========================================
  Files         304      304              
  Lines       33109    33161      +52     
==========================================
+ Hits        22438    22502      +64     
+ Misses      10671    10659      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm
Copy link
Collaborator

glihm commented Mar 27, 2024

The saya test was a bit flaky, it's fixed on main once #1710 is merged.

@tcoratger
Copy link
Contributor Author

The saya test was a bit flaky, it's fixed on main once #1710 is merged.

@glihm Let me know when we can merge this one and if we need to do something else here.

@glihm
Copy link
Collaborator

glihm commented Apr 1, 2024

The saya test was a bit flaky, it's fixed on main once #1710 is merged.

@glihm Let me know when we can merge this one and if we need to do something else here.

Amazing, thank you for all the work done here, will review shortly. 👍

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. Seems to me alloy-primitives is used in many crates, maybe it's better to have it on workspace level.

crates/katana/core/Cargo.toml Outdated Show resolved Hide resolved
crates/katana/core/src/backend/config.rs Show resolved Hide resolved
scripts/clippy.sh Outdated Show resolved Hide resolved
crates/saya/core/Cargo.toml Outdated Show resolved Hide resolved
scripts/clippy.sh Outdated Show resolved Hide resolved
@glihm glihm merged commit 24f40c6 into dojoengine:main Apr 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor katana This issue is related to Katana saya This issue is related to Saya (settlement)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from ethers to alloy
4 participants