Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging): update latestBlock to pending #1743

Conversation

ybensacq
Copy link
Contributor

No description provided.

@ybensacq ybensacq closed this Mar 31, 2024
@glihm
Copy link
Collaborator

glihm commented Apr 1, 2024

@ybensacq that's a good catch actually, is there something you wanted to add before opening it again? :)

@kwiss kwiss deleted the 7-bug-issue-when-sending-tx-used-block-is-the-last-one-instead-of-the-pending-one branch April 1, 2024 12:25
@ybensacq ybensacq restored the 7-bug-issue-when-sending-tx-used-block-is-the-last-one-instead-of-the-pending-one branch April 4, 2024 16:17
@ybensacq ybensacq reopened this Apr 4, 2024
@ybensacq
Copy link
Contributor Author

ybensacq commented Apr 4, 2024

@glihm reopened ! :-)

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.96%. Comparing base (3620d72) to head (a51ffa3).
Report is 157 commits behind head on main.

Files Patch % Lines
...ates/katana/core/src/service/messaging/starknet.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   68.03%   66.96%   -1.07%     
==========================================
  Files         228      305      +77     
  Lines       22074    33640   +11566     
==========================================
+ Hits        15017    22528    +7511     
- Misses       7057    11112    +4055     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this good catch @ybensacq!
@kariy if you have some other comment about that, let's know. 👍

I'm not sure we've integration testing for messaging yet, with the katana runner. I'll open an issue for that, where using the Katana test runner (and we should do one for anvil), integration testing for messaging could help detecting such kind of things.

@kariy kariy merged commit e974ee6 into dojoengine:main Apr 8, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants