[saya] Publish proof to Celestia #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
+ Coverage 68.21% 68.49% +0.27%
==========================================
Files 323 328 +5
Lines 40269 41058 +789
==========================================
+ Hits 27468 28121 +653
- Misses 12801 12937 +136 ☔ View full report in Codecov by Sentry. |
glihm
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Great work @neotheprogramist! Minor comments to be addressed.
| state_diff_proof.iter().flat_map(|fe| fe.to_bytes_be().to_vec()).collect(); | ||
| let proof_blob = Blob::new(self.namespace, proof_bytes)?; | ||
|
|
||
| // TODO: we may want to use `blob_get` to ensure the state diff has been published |
There was a problem hiding this comment.
If you're ok for doing it here, let's do it. If not, let's open an issue to keep track of that in the future.
glihm
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Including a proof blob into celestia DA.
Tests
As a local celestia instance is needed, tested as e2e.
Added to documentation?
Already present, only internal implementation changed.
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)