-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii-grpc): add events subscription #2065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
- Coverage 68.89% 68.34% -0.56%
==========================================
Files 326 327 +1
Lines 40793 41128 +335
==========================================
+ Hits 28104 28107 +3
- Misses 12689 13021 +332 ☔ View full report in Codecov by Sentry. |
|
||
for (idx, sub) in subs.subscribers.read().await.iter() { | ||
// publish all updates if ids is empty or only ids that are subscribed to | ||
if sub.keys.is_empty() || keys.starts_with(&sub.keys) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's the most common operation on regular event, we just want a sub-array from the beginning. We may update this later if needed.
We may document the behavior though, to ensure the user can understand the clause. I'll add an issue on the dojo-book to ensure that we describe better what's available and how. :)
Thanks for the work done here mate!
adds events subscription #2064