Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sozo): dev subcommand #2080

Merged
merged 11 commits into from
Jun 22, 2024
Merged

fix(sozo): dev subcommand #2080

merged 11 commits into from
Jun 22, 2024

Conversation

lambda-0x
Copy link
Collaborator

fix #2037

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 3.33333% with 87 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (4ff3bb9) to head (9104c03).

Files Patch % Lines
bin/sozo/src/commands/dev.rs 0.00% 67 Missing ⚠️
bin/sozo/src/commands/migrate.rs 0.00% 14 Missing ⚠️
bin/sozo/src/commands/options/transaction.rs 25.00% 3 Missing ⚠️
bin/sozo/src/commands/options/signer.rs 0.00% 1 Missing ⚠️
bin/sozo/src/commands/options/starknet.rs 0.00% 1 Missing ⚠️
bin/sozo/src/commands/options/world.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
+ Coverage   68.51%   68.71%   +0.20%     
==========================================
  Files         328      328              
  Lines       41037    40915     -122     
==========================================
  Hits        28116    28116              
+ Misses      12921    12799     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm
Copy link
Collaborator

glihm commented Jun 21, 2024

@lambda-0x mate, I proposed a new implementation mainly because we do need to take manifests in account when the project has to be migrated again. Hence, it's easier for us to re-use the existing commands that are already tested to build and migrate.

@glihm glihm marked this pull request as ready for review June 21, 2024 02:52
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework here @lambda-0x!

@glihm glihm merged commit ab33065 into main Jun 22, 2024
14 of 15 checks passed
@glihm glihm deleted the fix-dev branch June 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommand dev doesn't work as expected
2 participants