fix(torii-core): update entity timestamp on update #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
reviewed
Jun 28, 2024
| @@ -169,8 +169,8 @@ impl Sql { | |||
| let keys_str = felts_sql_string(&keys); | |||
| let insert_entities = "INSERT INTO entities (id, keys, event_id, executed_at) VALUES (?, \ | |||
| ?, ?, ?) ON CONFLICT(id) DO UPDATE SET \ | |||
| executed_at=EXCLUDED.executed_at, event_id=EXCLUDED.event_id \ | |||
| RETURNING *"; | |||
| updated_at=CURRENT_TIMESTAMP, executed_at=EXCLUDED.executed_at, \ | |||
There was a problem hiding this comment.
Is it the only location where we should do this fix? Don't we also update them on change?
There was a problem hiding this comment.
We update them on change there too. We do an upsert which is what the ON CONFLICT is for
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 331 331
Lines 41443 41443
=======================================
Hits 28323 28323
Misses 13120 13120 ☔ View full report in Codecov by Sentry. |
glihm
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2117