fix: change tag separator to -
#2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
glihm
added a commit
to Larkooo/dojo
that referenced
this pull request
Jul 3, 2024
* wip * fix tests
glihm
added a commit
that referenced
this pull request
Jul 5, 2024
* feat(torii-core): namespace in processor & db migration * refactor: selector logic and model readers for new namespace * feat: compute correct selector on model register * fix: contract address in event data * refactor: update proto for new namespace * feat: update torii client for new namespaces * refactor: cache and schema types * feat: rebase from main update to new types * feat: update grpc service to support namespaces * feat: add namespace to broker * feat: fix libp2p and update grpc subs for pattern on models * feat: finish up refactor on grpc * chore: revert changes on proto to use onlky model field * feat: first graphql support * fix: composite clauses & wrap up * fix: storage and tests * refactor: storage to use selector * fix: storage subscriptions * escape composite tbales * Overlays (#2127) * load custom overlay manifests * update metadata management + some fixes * update sozo commands with namespace * fix: change tag separator to `-` (#2132) * wip * fix tests * merge and remove print * fix: remove print * fix: fmt and clippy wip * fix: graphql tests * model tests * query test * fmt * fix: query * chore: graphql subscription tests * wip: fix testing * wip: wip on testing * fix: fix typo * fix: use correct model name * wip: testing * feat: add namespace to model object * fix: fix subscription tests * fix: fix tests * fix: fmt * fix: clippy * wip: latest torii test * fix: fmt * fix(torii-libp2p): validate namespace message * fix(torii-libp2p): escape table name * fmt --------- Co-authored-by: Rémy Baranx <remy.baranx@gmail.com> Co-authored-by: glihm <dev@glihm.net>
glihm
added a commit
that referenced
this pull request
Jul 7, 2024
* Namespace feature * Handle namespace for models and contracts (#2023) * fix(migrate): when `init_calldata` depends on contract that was already deployed (#2058) * fix(migrate): when `init_calldata` depends on contract that was already deployed * add tests * fix(ci): ensure katana runs in debian:bookworm-slim (#2073) * Ensure katana runs in debian:bookworm-slim * chore: switch to cartridge fork and adjust CI to 4 core to build Katana * chore: add old prover-sdk version to check CI fail * fix katana bin permissions * chore: add ensure-docker as requirement for big jobs * chore: point to http-prover using rustls-tls * dbg * wip * chore: bump to artifacts v4 * fix: typo * wip * fix: don't use path explicitely * wip * fix: fix artifacts managment * add ls * fix: use other path with checkout * fix: remove prints --------- Co-authored-by: glihm <dev@glihm.net> * [dojo-core]: update gas logs (#1877) dojo-core: update gas logs Co-authored-by: glihm <dev@glihm.net> * Prepare release: v0.7.1 (#2076) Co-authored-by: glihm <glihm@users.noreply.github.com> * fix: allow the use of self and world in an exclusive manner (#2063) * fix: allow the use of self and world in an exclusive manner * fix: fmt * fix: cairo fmt * fix: ensure a warning is emitted with generate trait and world * fix: cairo fmt * Update devcontainer image: v0.7.1 (#2077) Co-authored-by: glihm <glihm@users.noreply.github.com> * Namespace feature --------- Co-authored-by: lambda-0x <0xlambda@protonmail.com> Co-authored-by: Tarrence van As <tarrencev@users.noreply.github.com> Co-authored-by: glihm <dev@glihm.net> Co-authored-by: notV4l <122404722+notV4l@users.noreply.github.com> Co-authored-by: glihm <glihm@users.noreply.github.com> * fix: update manifests * fix: update manifests * fix: update world address in Scarb.toml * fix world_test * Namespace feature improvements (#2108) * standardize model/system interface for name/namespace/selectors * wip * Overlays (#2127) * load custom overlay manifests * update metadata management + some fixes * update sozo commands with namespace * fix: change tag separator to `-` (#2132) * wip * fix tests * update sozo auth command + auto-auth feature (#2134) * update sozo auth command + auto-auth feature * fix: fix some tests --------- Co-authored-by: glihm <dev@glihm.net> * replace {WORLD,BASE}_CONTRACT_NAME by {WORLD,BASE}_CONTRACT_TAG (#2136) * replace {WORLD,BASE}_CONTRACT_NAME by {WORLD,BASE}_CONTRACT_TAG * fix: ensure model selector correctly computed in tests * fix: wip on tests and use Katana Runner --------- Co-authored-by: glihm <dev@glihm.net> * fix(sozo): migration with seed and world address both provided (#2135) * initial commit * add seed to manifest and remove from cli * add overlays for dojo_init * make tests compile * fix some tests * fix lints * fix: use same name for seed tests --------- Co-authored-by: glihm <dev@glihm.net> * feat(torii-core): namespace in processor & db migration (#2130) * feat(torii-core): namespace in processor & db migration * refactor: selector logic and model readers for new namespace * feat: compute correct selector on model register * fix: contract address in event data * refactor: update proto for new namespace * feat: update torii client for new namespaces * refactor: cache and schema types * feat: rebase from main update to new types * feat: update grpc service to support namespaces * feat: add namespace to broker * feat: fix libp2p and update grpc subs for pattern on models * feat: finish up refactor on grpc * chore: revert changes on proto to use onlky model field * feat: first graphql support * fix: composite clauses & wrap up * fix: storage and tests * refactor: storage to use selector * fix: storage subscriptions * escape composite tbales * Overlays (#2127) * load custom overlay manifests * update metadata management + some fixes * update sozo commands with namespace * fix: change tag separator to `-` (#2132) * wip * fix tests * merge and remove print * fix: remove print * fix: fmt and clippy wip * fix: graphql tests * model tests * query test * fmt * fix: query * chore: graphql subscription tests * wip: fix testing * wip: wip on testing * fix: fix typo * fix: use correct model name * wip: testing * feat: add namespace to model object * fix: fix subscription tests * fix: fix tests * fix: fmt * fix: clippy * wip: latest torii test * fix: fmt * fix(torii-libp2p): validate namespace message * fix(torii-libp2p): escape table name * fmt --------- Co-authored-by: Rémy Baranx <remy.baranx@gmail.com> Co-authored-by: glihm <dev@glihm.net> * fix: fix compiler diags by rewriting the function with rewrite node (#2141) * fix: fix compiler diags by rewriting the function with rewrite node * fix: ensure dojo init also shows correct diagnostics * fix: fmt + clippy * fix: ensure impl is correctly impl with RewriteNode * fix: add missing mapping to interfaces * fix: ensure wasm compatibility * fix: test fixes for wasm32 changes (#2144) * fix: test fixes for wasm32 changes * fix: fix cairo tests * fix: clean subcommand (#2122) * fix: clean should only remove target/manifest file of particular profile by defaul * fix lints * fix formatting * fix: ensure every target is considered independently --------- Co-authored-by: glihm <dev@glihm.net> * fix: uncomment tests * fix: add more tests * fix: fix metadata test * fix: add tests and fix metadata * fix: attempt to fix flaky test with 1s delay --------- Co-authored-by: remy.baranx@gmail.com <remy.baranx@gmail.com> Co-authored-by: lambda-0x <0xlambda@protonmail.com> Co-authored-by: Tarrence van As <tarrencev@users.noreply.github.com> Co-authored-by: notV4l <122404722+notV4l@users.noreply.github.com> Co-authored-by: glihm <glihm@users.noreply.github.com> Co-authored-by: notV4l <imV4l@proton.me> Co-authored-by: Larko <59736843+Larkooo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the tag separator to have the same for tag and filename (as the tag is path safe now).
Fixes some tests, excluding
auth, @remybar will let you check those when making your PR for theauth. 🫡Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)