fix(katana-node-bindings): use new Felt #2146
Conversation
WalkthroughThe changes primarily consist of updating the data type from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
glihm
changed the title
glihm
changed the title
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (3)
- crates/katana/node-bindings/Cargo.toml (1 hunks)
- crates/katana/node-bindings/src/lib.rs (9 hunks)
- crates/katana/runner/src/lib.rs (3 hunks)
Files skipped from review due to trivial changes (1)
- crates/katana/node-bindings/Cargo.toml
Additional comments not posted (11)
crates/katana/runner/src/lib.rs (3)
26-26: Change Approved: Updatedcontractfield to useFelt.The
contractfield in theKatanaRunnerstruct has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
153-153: Change Approved: Updatedset_contractmethod to useFelt.The
set_contractmethod's parameter type has been updated toFelt. This change is consistent with the objective to use the new Felt type.
158-158: Change Approved: Updatedcontractmethod to useFelt.The
contractmethod's return type has been updated toFelt. This change is consistent with the objective to use the new Felt type.crates/katana/node-bindings/src/lib.rs (8)
16-16: Change Approved: Updated import statement to useFelt.The import statement has been updated to import
Feltinstead ofFieldElement. This change is consistent with the objective to use the new Felt type.
32-32: Change Approved: Updatedaddressfield inAccountstruct to useFelt.The
addressfield in theAccountstruct has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
45-45: Change Approved: Updatedchain_idfield inKatanaInstancestruct to useFelt.The
chain_idfield in theKatanaInstancestruct has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
65-65: Change Approved: Updatedchain_idmethod inKatanaInstancestruct to returnFelt.The
chain_idmethod in theKatanaInstancestruct has been updated to returnFelt. This change is consistent with the objective to use the new Felt type.
338-338: Change Approved: Updatedchain_idmethod inKatanabuilder to acceptFelt.The
chain_idmethod in theKatanabuilder has been updated to acceptFelt. This change is consistent with the objective to use the new Felt type.
511-511: Change Approved: Updatedaddressassignment inspawnmethod to useFelt.The
addressassignment in thespawnmethod has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
512-512: Change Approved: Updatedprivate_keyassignment inspawnmethod to useFelt.The
private_keyassignment in thespawnmethod has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
569-569: Change Approved: Updatedprivate_keyassignment inspawnmethod to useFelt.The
private_keyassignment in thespawnmethod has been updated to useFelt. This change is consistent with the objective to use the new Felt type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 68.13% 67.82% -0.32%
==========================================
Files 334 334
Lines 41894 42048 +154
==========================================
- Hits 28546 28519 -27
- Misses 13348 13529 +181 ☔ View full report in Codecov by Sentry. |
Description
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)Summary by CodeRabbit
FieldElementtoFeltacross various structs and methods to reflect improved data representation. This change impacts how addresses, chain IDs, and private keys are handled within the application.