Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure metadata loading errors are correctly logged #2149

Merged
merged 1 commit into from
Jul 7, 2024

fix: ensure metadata loading errors are correctly logged

aac2854
Select commit
Loading
Failed to load commit list.
Merged

fix: ensure metadata loading errors are correctly logged #2149

fix: ensure metadata loading errors are correctly logged
aac2854
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 7, 2024 in 0s

67.88% (-0.02%) compared to ed9f0ce, passed because coverage increased by -0.01% when compared to adjusted base (67.89%)

View this Pull Request on Codecov

67.88% (-0.02%) compared to ed9f0ce, passed because coverage increased by -0.01% when compared to adjusted base (67.89%)

Details

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (ed9f0ce) to head (aac2854).

Files Patch % Lines
bin/sozo/src/commands/build.rs 53.33% 7 Missing ⚠️
crates/dojo-world/src/metadata.rs 76.92% 3 Missing ⚠️
bin/sozo/src/commands/auth.rs 0.00% 1 Missing ⚠️
bin/sozo/src/commands/call.rs 0.00% 1 Missing ⚠️
bin/sozo/src/commands/execute.rs 0.00% 1 Missing ⚠️
bin/sozo/src/commands/model.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
- Coverage   67.89%   67.88%   -0.02%     
==========================================
  Files         336      336              
  Lines       43086    43094       +8     
==========================================
+ Hits        29255    29256       +1     
- Misses      13831    13838       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.