fix: ensure correct compilation unit is picked up

[glihm]

Description

Ensures the compilation units are correctly picked up during test phase + CfgSet correctly set for every component of the compilation unit as they override the db.cfg_set() if they are not None.

Summary by CodeRabbit

• New Features

  • Enhanced package handling by transitioning from package identifiers to human-readable package names for improved clarity.
  • Updated compilation options to streamline the process and allow broader target specifications.

• Bug Fixes

  • Refined filtering logic for compilation units to ensure only relevant units are processed based on package names.

• Chores

  • Simplified namespace configuration to streamline control flow and reduce complexity.
  • Updated configuration to disable specific settings, potentially simplifying the build process.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent updates enhance the TestArgs implementation by shifting from package identifiers to human-readable package names, which improves clarity and usability. Additionally, the CompileOpts structure has been refined, emphasizing package names for filtering and compilation. This streamlining simplifies the handling of compilation options and enhances overall functionality related to package management.

Changes

Files	Change Summary
bin/sozo/src/commands/test.rs	Updated TestArgs to collect package names instead of IDs. Modified CompileOpts to utilize package names directly and streamlined the filtering logic for compilation_units.
crates/dojo-lang/src/plugin.rs	Removed conditional namespace configuration for the "test" target, simplifying the namespace handling based on metadata. Reduced dependencies for cleaner code.
examples/spawn-and-move/Scarb.toml	Commented out dojo profile settings, including merge-strategy and skip_migration, indicating a shift in handling build configurations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TestArgs
    participant CompileOpts
    participant CompilationUnits
    
    User->>TestArgs: Input package names
    TestArgs->>CompileOpts: Set include_target_names with package names
    CompileOpts->>CompilationUnits: Filter based on include_target_names
    CompilationUnits-->>CompileOpts: Return relevant units
    CompileOpts-->>TestArgs: Compilation options ready
    TestArgs-->>User: Complete test setup

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c318bf0 and 487ee17.

Files selected for processing (1)

• bin/sozo/src/commands/test.rs (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• bin/sozo/src/commands/test.rs

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[glihm]

It works on some package, but not on others.
For instance the origami library being built in it's own repo -> both work.
If we import origami in an other crates, only the one that is not unittest works.
In spawn and move, only the unittest works.

[codecov]

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (8bcdc3b) to head (487ee17).
Report is 2 commits behind head on main.

Files	Patch %	Lines
bin/sozo/src/commands/test.rs	89.79%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
+ Coverage   69.82%   70.09%   +0.27%     
==========================================
  Files         340      340              
  Lines       44764    44802      +38     
==========================================
+ Hits        31256    31405     +149     
+ Misses      13508    13397     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.