Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize cairo to 2.7.0 #2257

Merged
merged 13 commits into from
Aug 5, 2024
Merged

feat: stabilize cairo to 2.7.0 #2257

merged 13 commits into from
Aug 5, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Aug 2, 2024

Stabilizes the cairo version before the network bump to cairo 2.7.0 to ensure compatibility.

Summary by CodeRabbit

  • New Features

    • Updated several dependencies to their stable versions, enhancing stability and reliability.
  • Chores

    • Updated Docker image references in CI/CD workflows for consistent behavior.
    • Simplified code by removing unnecessary operations in the TypeScript plugin.
    • Improved SQL query binding for enhanced readability.
    • Modified test input values to improve accuracy in assertions.

Copy link

coderabbitai bot commented Aug 2, 2024

Walkthrough

Ohayo, sensei! The recent updates significantly enhance the Rust project by transitioning multiple dependencies from release candidates to stable versions, improving reliability and stability. Additionally, the Docker image references in the CI workflow have been updated to specific commit hashes, ensuring consistent behavior during CI/CD processes. These improvements reflect a strong commitment to refining the overall development environment.

Changes

Files Change Summary
Cargo.toml Updated multiple dependencies from release candidates to stable versions, signaling a move towards stability.
.github/workflows/ci.yml Updated Docker image references to specific commit hashes for consistency in CI jobs.
crates/dojo-bindgen/src/plugins/typescript_v2/mod.rs, crates/torii/core/src/sql.rs Refined code by removing unnecessary string formatting operations to streamline functionality.
crates/sozo/ops/src/tests/model.rs Modified test inputs with new hexadecimal values, potentially affecting test outcomes.

Sequence Diagram(s)

sequenceDiagram
    participant A as Developer
    participant B as Dependency Manager
    participant C as CI/CD System

    A->>B: Update dependencies to stable versions
    B->>C: Ensure compatibility with stable releases
    C-->>A: Run CI/CD with updated configurations
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cfbfc10 and 359f14c.

Files selected for processing (1)
  • crates/sozo/ops/src/tests/model.rs (2 hunks)
Additional comments not posted (2)
crates/sozo/ops/src/tests/model.rs (2)

28-28: Ohayo, sensei! Verify the correctness of the new hexadecimal value.

Ensure that 0x2bfdf50f9ec0670b52065947e6ce2e1ebb39d54d19da1b65411b6d58bb04e79 is the correct expected value for the model_class_hash function.


40-40: Ohayo, sensei! Verify the correctness of the new hexadecimal value.

Ensure that 0x59d2704cd3ce6ea22ae73b0c68e100b80e1f85ac4d4be5cbc66f6f8b9f1c268 is the correct expected value for the model_contract_address function.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
crates/katana/storage/codecs/derive/Cargo.toml (1)

20-21: Ohayo, sensei! New feature section added.

The addition of the [features] section with the postcard feature looks good. Consider adding documentation to explain the purpose and usage of this new feature.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (9834932) to head (359f14c).

Files Patch % Lines
crates/dojo-world/abigen/src/main.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2257   +/-   ##
=======================================
  Coverage   70.28%   70.29%           
=======================================
  Files         345      345           
  Lines       45434    45428    -6     
=======================================
- Hits        31934    31933    -1     
+ Misses      13500    13495    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glihm glihm merged commit 705ebad into main Aug 5, 2024
14 of 15 checks passed
@glihm glihm deleted the bump-cairo-270 branch August 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants