-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(torii-client): remove deprecated model storage and subscription #2267
Conversation
WalkthroughOhayo, sensei! The recent changes streamline the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Additional comments not posted (19)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
crates/torii/client/src/lib.rs (1)
5-5
: Ohayo, sensei! Theutils
module has been made private.The change could indeed impact external code relying on the
utils
module. The search results show numerous references toutils
across different crates, indicating potential issues.
- Locations to review:
crates/torii/core/src/sql.rs
crates/torii/graphql/src/schema.rs
crates/torii/graphql/src/tests/subscription_test.rs
crates/torii/graphql/src/object/event_message.rs
crates/torii/graphql/src/object/inputs/keys_input.rs
crates/torii/graphql/src/object/mod.rs
crates/torii/graphql/src/object/model_data.rs
crates/torii/graphql/src/object/entity.rs
Please ensure that all dependencies are updated accordingly.
Analysis chain
Ohayo, sensei! The
utils
module has been made private.This change could impact any external code that relied on the
utils
module. Ensure that all dependencies are updated accordingly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `utils` module in the codebase. # Test: Search for the usage of the `utils` module. Expect: No occurrences of the `utils` module outside the crate. rg --type rust -A 5 $'utils::'Length of output: 125717
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
+ Coverage 70.24% 70.40% +0.16%
==========================================
Files 345 342 -3
Lines 45466 45018 -448
==========================================
- Hits 31938 31697 -241
+ Misses 13528 13321 -207 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Bug Fixes
Chores
utils
module from public visibility, simplifying the library's structure.