-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: taplo fmt
#2336
chore: taplo fmt
#2336
Conversation
WalkthroughOhayo, sensei! The recent changes encompass modifications across multiple Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Cargo
participant Workspace
Developer->>Cargo: Update dependencies
Cargo->>Workspace: Reorganize dependencies
Workspace-->>Cargo: Updated configuration
Cargo-->>Developer: Confirm changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (23)
Files skipped from review due to trivial changes (8)
Files skipped from review as they are similar to previous changes (11)
Additional comments not posted (11)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 355 355
Lines 46414 46414
=======================================
Hits 31200 31200
Misses 15214 15214 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
examples/spawn-and-move/manifests/dev/base/contracts/dojo_examples-others-61de2c18.toml (1)
9-9
: Consider future use ofsystems
.The
systems
property is introduced as an empty array. Consider documenting its intended use or future plans for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner! The only downside is that the auto-generated files like manifests are modified, and this will cause some diffs that are not significant.
Any chance we could ignore them in the taplo
run?
yup agree. i've modified the taplo config to target |
taplo fmt
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Cargo.toml
files, aiding readability.