Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: taplo fmt #2336

Merged
merged 2 commits into from
Aug 23, 2024
Merged

chore: taplo fmt #2336

merged 2 commits into from
Aug 23, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Aug 23, 2024

taplo fmt

Summary by CodeRabbit

  • New Features

    • Improved workspace configuration for various dependencies, enhancing organization and dependency management across multiple projects.
  • Bug Fixes

    • Adjusted dependencies to ensure proper inclusion and ordering within the workspace, which may improve build efficiency.
  • Chores

    • Minor formatting changes for consistency and clarity in various Cargo.toml files, aiding readability.

Copy link

coderabbitai bot commented Aug 23, 2024

Walkthrough

Ohayo, sensei! The recent changes encompass modifications across multiple Cargo.toml files in the project. These alterations primarily involve reorganizing workspace dependencies, updating specific dependency versions, and adjusting configuration formatting. Several fields within manifest files have been reordered or explicitly defined, enhancing clarity and consistency in the project's structure.

Changes

Files Change Summary
Cargo.toml Commented out "crates/benches"; uncommented "crates/dojo-utils"; reordered reqwest features.
bin/katana/Cargo.toml Activated katana-rpc, added version specifications for byte-unit and comfy-table; reinstated dojo-utils.
bin/saya/Cargo.toml Adjusted workspace settings for tracing and tracing-subscriber.
bin/sozo/Cargo.toml Added workspace entries for several dependencies; reorganized existing ones.
bin/torii/Cargo.toml Reordered entries in workspace dependencies.
crates/dojo-core/Cargo.toml Adjusted indentation in pre-release-replacements section.
crates/dojo-lang/Cargo.toml Reintroduced cairo-lang-starknet-classes into workspace dependencies.
crates/dojo-types/Cargo.toml Added cainome.workspace and serde_json.workspace; removed previous declarations.
crates/dojo-world/Cargo.toml Adjusted order of cairo-lang-starknet and starknet entries.
crates/dojo-world/abigen/Cargo.toml Set edition.workspace to true; reorganized dependencies.
crates/katana/rpc/rpc/Cargo.toml Enabled dojo-world.workspace.
crates/katana/runner/runner-macro/Cargo.toml Reordered features in syn dependency; noted duplicate edition entry.
crates/metrics/Cargo.toml Uncommented metrics.workspace declaration.
crates/saya/core/Cargo.toml Added once_cell.workspace and removed redundant declaration.
crates/torii/graphql/Cargo.toml Uncommented dojo-world.workspace.
crates/torii/grpc/Cargo.toml Reordered dojo-world and katana-runner dependencies.
crates/torii/server/Cargo.toml Reordered http-body, tokio-util, and tower-http dependencies.
crates/torii/types-test/Cargo.toml Formatting adjustment in pre-release-replacements section.
examples/spawn-and-move/Cargo.toml Standardized whitespace in [package.metadata.release] section.
taplo.toml Added include and indent_string parameters for improved configuration management.
xtask/generate-test-db/Cargo.toml Moved reqwest dependency after tokio; added back tokio.workspace.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Cargo
    participant Workspace

    Developer->>Cargo: Update dependencies
    Cargo->>Workspace: Reorganize dependencies
    Workspace-->>Cargo: Updated configuration
    Cargo-->>Developer: Confirm changes
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c720325 and 2cc6fff.

Files selected for processing (23)
  • Cargo.toml (2 hunks)
  • bin/katana/Cargo.toml (1 hunks)
  • bin/saya/Cargo.toml (1 hunks)
  • bin/sozo/Cargo.toml (2 hunks)
  • bin/torii/Cargo.toml (2 hunks)
  • crates/dojo-core/Cargo.toml (1 hunks)
  • crates/dojo-lang/Cargo.toml (1 hunks)
  • crates/dojo-types/Cargo.toml (1 hunks)
  • crates/dojo-world/abigen/Cargo.toml (1 hunks)
  • crates/katana/rpc/rpc/Cargo.toml (1 hunks)
  • crates/katana/runner/runner-macro/Cargo.toml (1 hunks)
  • crates/saya/core/Cargo.toml (1 hunks)
  • crates/sozo/ops/Cargo.toml (2 hunks)
  • crates/torii/client/Cargo.toml (1 hunks)
  • crates/torii/core/Cargo.toml (1 hunks)
  • crates/torii/graphql/Cargo.toml (2 hunks)
  • crates/torii/grpc/Cargo.toml (3 hunks)
  • crates/torii/libp2p/Cargo.toml (1 hunks)
  • crates/torii/server/Cargo.toml (1 hunks)
  • crates/torii/types-test/Cargo.toml (1 hunks)
  • examples/spawn-and-move/Cargo.toml (1 hunks)
  • taplo.toml (2 hunks)
  • xtask/generate-test-db/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (8)
  • bin/saya/Cargo.toml
  • bin/sozo/Cargo.toml
  • bin/torii/Cargo.toml
  • crates/dojo-core/Cargo.toml
  • crates/katana/runner/runner-macro/Cargo.toml
  • crates/sozo/ops/Cargo.toml
  • crates/torii/server/Cargo.toml
  • crates/torii/types-test/Cargo.toml
Files skipped from review as they are similar to previous changes (11)
  • Cargo.toml
  • crates/dojo-lang/Cargo.toml
  • crates/dojo-types/Cargo.toml
  • crates/dojo-world/abigen/Cargo.toml
  • crates/katana/rpc/rpc/Cargo.toml
  • crates/saya/core/Cargo.toml
  • crates/torii/graphql/Cargo.toml
  • crates/torii/grpc/Cargo.toml
  • examples/spawn-and-move/Cargo.toml
  • taplo.toml
  • xtask/generate-test-db/Cargo.toml
Additional comments not posted (11)
bin/katana/Cargo.toml (5)

Line range hint 13-13: Ohayo, sensei! Added katana-rpc to the workspace.

This change helps in better managing the katana-rpc dependency as part of the workspace. Nice move!


20-20: Ohayo, sensei! Added byte-unit with version 5.1.4.

Specifying the version ensures consistent builds. Great job!


23-23: Ohayo, sensei! Added comfy-table with version 7.1.1.

Locking the version helps maintain consistency. Well done!


25-25: Ohayo, sensei! Added dojo-utils to the workspace.

This inclusion indicates its growing role in the project. Nice update!


27-27: Ohayo, sensei! Added tracing to the workspace.

This addition can enhance logging and monitoring. Good choice!

crates/torii/client/Cargo.toml (3)

14-14: Ohayo, sensei! Added futures-util to the workspace.

This inclusion enhances async programming capabilities. Well done!


21-21: Ohayo, sensei! Added starknet-crypto to the workspace.

This inclusion indicates its growing role in the project. Nice update!


12-12: Ohayo, sensei! Added futures to the workspace.

This addition enhances async programming capabilities. Great choice!

crates/torii/core/Cargo.toml (1)

35-35: Ohayo, sensei! Added starknet-crypto to the workspace.

This inclusion indicates its growing role in the project. Nice update!

crates/torii/libp2p/Cargo.toml (2)

26-26: Verify the addition of starknet-crypto.workspace.

Ohayo, sensei! The addition of starknet-crypto.workspace seems to enhance cryptographic functionalities. Please confirm that this change aligns with the PR's focus on formatting and is not an unintended modification.


29-29: Verify the re-addition of tracing-subscriber.

Ohayo, sensei! The re-addition of tracing-subscriber with a specific version and features ensures logging capabilities. Please confirm that this change aligns with the PR's focus on formatting and is not an unintended modification.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.22%. Comparing base (1cf67f8) to head (2cc6fff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files         355      355           
  Lines       46414    46414           
=======================================
  Hits        31200    31200           
  Misses      15214    15214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
examples/spawn-and-move/manifests/dev/base/contracts/dojo_examples-others-61de2c18.toml (1)

9-9: Consider future use of systems.

The systems property is introduced as an empty array. Consider documenting its intended use or future plans for clarity.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! The only downside is that the auto-generated files like manifests are modified, and this will cause some diffs that are not significant.

Any chance we could ignore them in the taplo run?

@kariy
Copy link
Member Author

kariy commented Aug 23, 2024

Much cleaner! The only downside is that the auto-generated files like manifests are modified, and this will cause some diffs that are not significant.

Any chance we could ignore them in the taplo run?

yup agree. i've modified the taplo config to target Cargo.toml files only.

@kariy kariy merged commit 51a678b into main Aug 23, 2024
15 checks passed
@kariy kariy deleted the chore/taplo branch August 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants