-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sozo): ensure already registered resources don't make migration fail #2350
Conversation
Caution Review failedThe pull request is closed. WalkthroughOhayo, sensei! The changes involve significant modifications to the migration process in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MigrationProcess
participant World
User->>MigrationProcess: Initiate migration
MigrationProcess->>World: Check registered namespaces
World-->>MigrationProcess: Return registered namespaces
MigrationProcess->>MigrationProcess: Filter out already registered namespaces
MigrationProcess->>World: Register new namespaces
MigrationProcess->>World: Check declared models
World-->>MigrationProcess: Return declared models
MigrationProcess->>MigrationProcess: Filter out already declared models
MigrationProcess->>World: Register new models
MigrationProcess->>User: Print migration summary
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 359 359
Lines 46853 46871 +18
=======================================
+ Hits 31634 31647 +13
- Misses 15219 15224 +5 ☔ View full report in Codecov by Sentry. |
Description
As now the core is panicking if a resource is already registered, we need to check first if the resource if not already registered.
This check wasn't done for namespaces and models.
For testing, we need a way to avoid compiling from the code due to too long times. A script should be ok to modify actions and try to migrate again.
Summary by CodeRabbit
New Features
Bug Fixes