Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: pin exact rust nightly version #2365

Merged
merged 8 commits into from
Aug 29, 2024
Merged

dev: pin exact rust nightly version #2365

merged 8 commits into from
Aug 29, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Aug 29, 2024

pin rust nightly version used in devcontainer for ci and in the scripts (ie ./scripts) to nightly-2024-08-28 version.

the version is chosen to match the version that the latest devcontainer was built with

Summary by CodeRabbit

  • New Features

    • Updated to utilize a specific nightly Rust toolchain version for improved stability and feature access.
  • Bug Fixes

    • Adjusted linting and formatting scripts to ensure compatibility with the specified nightly Rust version, potentially improving code analysis and formatting results.

@kariy kariy requested a review from glihm August 29, 2024 17:14
Copy link

coderabbitai bot commented Aug 29, 2024

Walkthrough

Ohayo, sensei! The changes involve updating the Rust toolchain version in the development environment. A new environment variable, nightly_rust_toolchain_version, is introduced to specify the nightly version as "nightly-2024-08-28". This update is reflected in the Dockerfile and scripts for Clippy and Rust formatting, ensuring all components utilize the specified nightly version for consistency.

Changes

Files Change Summary
.devcontainer/Dockerfile Introduced nightly_rust_toolchain_version to specify the nightly version and updated installation command to use this variable.
scripts/clippy.sh, scripts/rust_fmt.sh Changed Rust toolchain version from nightly to nightly-2024-08-28 in both scripts.

Sequence Diagram(s)

sequenceDiagram
    participant DevContainer
    participant RustToolchain
    participant Clippy
    participant RustFmt

    DevContainer->>RustToolchain: Install nightly-2024-08-28
    RustToolchain-->>DevContainer: Toolchain installed
    DevContainer->>Clippy: Run linting with nightly-2024-08-28
    Clippy-->>DevContainer: Linting results
    DevContainer->>RustFmt: Format code with nightly-2024-08-28
    RustFmt-->>DevContainer: Formatting complete
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 03daa6b and 032d68f.

Files selected for processing (1)
  • .devcontainer/Dockerfile (3 hunks)
Additional comments not posted (3)
.devcontainer/Dockerfile (3)

30-31: Ohayo, sensei! This change looks good to me.

The addition of the nightly_rust_toolchain_version environment variable improves maintainability and ensures consistency in the Rust nightly version across the development environment and CI processes.


41-42: Ohayo, sensei! This change looks good to me.

The update to the installation command for the nightly toolchain enhances the flexibility of the build process by using the nightly_rust_toolchain_version environment variable.


65-65: Ohayo, sensei! This change looks good to me.

The update to the installation command for the platform-specific tooling ensures that the correct nightly version is used.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (13cee86) to head (032d68f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   67.49%   67.65%   +0.15%     
==========================================
  Files         359      359              
  Lines       46971    46927      -44     
==========================================
+ Hits        31704    31747      +43     
+ Misses      15267    15180      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit e89ac13 into main Aug 29, 2024
15 of 17 checks passed
@kariy kariy deleted the sync-nightly-version branch August 29, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant