Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows) add GitHub Actions workflow for preview builds #2446
ci(workflows) add GitHub Actions workflow for preview builds #2446
Changes from 13 commits
6c6b40d
26ad014
662d194
0fa007b
6605027
c130548
ce3441c
5a4bec7
27e445c
2d4a062
e9076a6
0dcec2c
a18222b
259fb63
ea45f9d
053a4b5
c781b15
4afe768
48c8e0a
d9c53d1
44e5efc
64d19a1
c91600f
3198ed2
87d2b3e
ec35a9d
3f8d57b
cb80ecc
cf7cc62
55819aa
ba0273b
a09b21b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Swatinem/rust-cache action to a newer version
Ohayo, sensei! The
Swatinem/rust-cache@v1
action is outdated. Updating to the latest version will ensure better compatibility and performance.Apply this diff to update the action version:
Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary 'repo-token' input from 'arduino/setup-protoc@v2'
Ohayo, sensei! The
repo-token
input is not required for thearduino/setup-protoc@v2
action. Removing it can prevent potential misconfigurations.Apply this diff to remove the unnecessary input:
- uses: arduino/setup-protoc@v2 with: - repo-token: ${{ secrets.GITHUB_TOKEN }} version: "25.x"
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undefined 'prepare' in 'needs.prepare.outputs.tag_name'
Ohayo, sensei! The variable
needs.prepare.outputs.tag_name
refers to a job namedprepare
, which isn't defined in the workflow. This will cause the workflow to fail due to an undefined reference.To fix this, either define a
prepare
job that outputstag_name
, or modify the variable to correctly reference an existing job's output. Iftag_name
is not needed, you can set a default value.For example, set
VERSION_NAME
to a default value:Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShellCheck SC2086: Quote variables to prevent globbing and word splitting
Ohayo, sensei! In your shell script, the variable
$GITHUB_OUTPUT
should be wrapped in double quotes to prevent word splitting and globbing issues.Apply this diff to fix the issue:
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update actions/checkout action to the latest version
Ohayo, sensei! The
actions/checkout@v2
action is outdated. Updating to the latest version will provide consistency and utilize the latest features.Apply this diff to update the action version:
Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update docker/setup-buildx-action to the latest version
Ohayo, sensei! The
docker/setup-buildx-action@v1
action is outdated. Updating to the latest version ensures improved functionality and support.Apply this diff to update the action version:
Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update docker/login-action to the latest version
Ohayo, sensei! The
docker/login-action@v1
action is outdated. Updating to the latest version will enhance security and compatibility.Apply this diff to update the action version:
Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShellCheck SC2086: Quote variables to prevent globbing and word splitting
Ohayo, sensei! In your shell script, the variable
$GITHUB_OUTPUT
should be wrapped in double quotes to prevent word splitting and globbing issues.Apply this diff to fix the issue:
Committable suggestion