fix(torii): use correct query_type

[lambda-0x]

Summary by CodeRabbit

• New Features

  • Introduced a new test to ensure that setting an entity message in the SQL database triggers a publish event on the broker.

• Bug Fixes

  • Adjusted query type handling to better associate with event messages, enhancing query execution accuracy.

[coderabbitai]

Walkthrough

Ohayo, sensei! This pull request introduces a modification in the Sql implementation by changing the second argument of a function call from QueryType::Other to QueryType::EventMessage(entity.clone()). Additionally, it adds a new asynchronous test function to verify that setting an entity message in the SQL database triggers a publish event on a broker.

Changes

File	Change Summary
crates/torii/core/src/sql.rs	Modified the function call in the Sql implementation to change the query type from Other to EventMessage(entity.clone()).
crates/torii/libp2p/src/tests.rs	Added a new asynchronous test function test_entity_message_trigger_publish to verify event message publishing on the broker.

Possibly related PRs

• refactor(torii): update query logic for them to not block #2397: This PR involves modifications to the QueryType enum and its usage in the QueryQueue, which is directly related to the changes in the main PR regarding query type handling.
• refactor(torii-core): enqueue models & events #2471: This PR also modifies the QueryType enum and its handling within the QueryQueue, aligning with the main PR's changes on how queries are categorized and processed.

Suggested reviewers

• glihm: Suggested as a reviewer for the changes made in this pull request.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

crates/torii/core/src/sql.rs (1)

315-315: Ohayo, sensei! This change looks good to me!

The modification to use QueryType::EventMessage(entity.clone()) instead of QueryType::Other is a nice improvement. It provides more specific typing for event message queries, which could enhance query handling and tracking.

As a small suggestion, consider adding a brief comment explaining why this specific query type is used for event messages. It might help future maintainers understand the reasoning behind this choice.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8453b63 and 8b51500.

📒 Files selected for processing (1)

• crates/torii/core/src/sql.rs (1 hunks)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (8453b63) to head (1084e35).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
+ Coverage   68.45%   68.50%   +0.04%     
==========================================
  Files         368      368              
  Lines       48139    48186      +47     
==========================================
+ Hits        32955    33010      +55     
+ Misses      15184    15176       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lambda-0x]

added a (hacky) test to avoid future regressions

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

crates/torii/libp2p/src/tests.rs (2)

693-695: Handle potential initialization errors from tracing_subscriber

Ohayo sensei! The possible error from try_init() is currently being ignored. While this might be acceptable in a test environment, explicitly handling or logging the error can aid in debugging if the initialization fails.

---

719-720: Address the FIXME regarding entity name handling

Ohayo sensei! I noticed a FIXME indicating that register_model and set_event_message handle the name and namespace of the entity type differently. This inconsistency could lead to potential bugs or unexpected behavior. It would be beneficial to standardize how entity names and namespaces are managed in both methods to ensure consistency across the codebase.

Would you like me to help refactor the code to address this issue or open a GitHub issue to track this task?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8b51500 and 1084e35.

📒 Files selected for processing (2)

• crates/torii/core/src/sql.rs (1 hunks)
• crates/torii/libp2p/src/tests.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/torii/core/src/sql.rs