Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added simple AMM to defi crate #261

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Added simple AMM to defi crate #261

merged 3 commits into from
Apr 28, 2023

Conversation

broody
Copy link
Collaborator

@broody broody commented Apr 25, 2023

Ported the simple amm from RYO, so trading pair is cash:item. Should really be token:token to make it more generic.

milancermak
milancermak reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@milancermak milancermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a way how to add and remove liquidity to the market.

crates/dojo-defi/src/constant_product_market/components.cairo Outdated Show resolved Hide resolved
@tarrencev tarrencev merged commit 5851f5a into main Apr 28, 2023
@tarrencev tarrencev deleted the amm branch April 28, 2023 17:24
@broody broody mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancermak milancermak milancermak left review comments

@tarrencev tarrencev tarrencev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broody @milancermak @tarrencev