Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert making saving samples async #2882

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Revert making saving samples async #2882

merged 3 commits into from
Dec 9, 2020

Conversation

roji
Copy link
Member

@roji roji commented Nov 17, 2020

Closes #2754

@roji roji marked this pull request as ready for review November 17, 2020 17:09
@roji roji mentioned this pull request Nov 18, 2020
Closed
@roji roji linked an issue Nov 18, 2020 that may be closed by this pull request
Concern regarding possible resource leak #2886
Closed
@roji roji merged commit cd63879 into master Dec 9, 2020
@ajcvickers ajcvickers mentioned this pull request Dec 10, 2020
Closed
@smitpatel smitpatel deleted the SaveSynchronously branch December 15, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concern regarding possible resource leak Samples: async or sync?
2 participants
@roji @bricelam