Bug510 #511
Merged
Bug510 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding 'num_batches_tracked' to BatcNorm{123}d
lostmsu
reviewed
Feb 13, 2022
|
Mostly looks good to me, except the |
lostmsu
reviewed
Feb 14, 2022
lostmsu
approved these changes
Feb 14, 2022
| var splits = target.Split('.'); | ||
| if (splits.Length > 1) { | ||
| foreach (var child in named_children().Where(nc => nc.name == splits[0])) { | ||
| if (child.module.has_parameter(target.Remove(0, splits[0].Length + 1))) |
There was a problem hiding this comment.
NIT: target[(splits[0].Length + 2)..]
There was a problem hiding this comment.
Worth doing if it's more than trivially faster, otherwise I'll leave as is.
Comment on lines
+536
to
+550
| if (target is null) throw new ArgumentNullException("target"); | ||
| if (_internal_buffers.TryGetValue(target, out var buffer)) { | ||
| return buffer; | ||
| } | ||
|
|
||
| var splits = target.Split('.'); | ||
| if (splits.Length > 1) { | ||
| foreach (var child in named_children().Where(nc => nc.name == splits[0])) { | ||
| var p = child.module.get_buffer(target.Remove(0, splits[0].Length + 1)); | ||
| if (p is not null) | ||
| return p; | ||
| } | ||
| } | ||
| return null; | ||
| } |
There was a problem hiding this comment.
NIT: this repeats a bit. Perhaps make a T get_named<T>(name, internal_collection, getter)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #510