Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manifest-attribute-codegen] Automatically generate manifest attributes from Android SDK data. #8781

Merged
merged 4 commits into from
Jun 7, 2024
Merged

[manifest-attribute-codegen] Automatically generate manifest attributes from Android SDK data. #8781

merged 4 commits into from
Jun 7, 2024

Commits on Mar 22, 2024

  1. [manifest-attribute-codegen] Automatically generate manifest attribut… 

    …es from Android SDK data.
    @jpobst
    jpobst committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    20e0fef View commit details
    Browse the repository at this point in the history

  2. Generate mappings used by Xamarin.Android.Build.Tasks.

    @jpobst
    jpobst committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4286992 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Additional documentation.

    @jpobst
    jpobst committed May 17, 2024
    Configuration menu
    Copy the full SHA
    56122eb View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Various review bits 

    Review and update `README.md` so that @jonpryor understands it.
In particular, `xaprepare android-sdk-platforms=all` Is Not A Thing™
and needed to be replaced with a command that actually worked.

Update `manifest-attribute-codegen` to:

  * Normalize the output path so that it works properly on macOS/Linux
  * Has a comment after `#endif // XABT_MANIFEST_EXTENSIONS`, because
    @jonpryor thinks code is clearer that way.
    (This is also how I found out that paths needed to be normalized!)
  * Remove extraneous whitespace from `<AppendTargetFrameworkToOutputPath/>`.
  * Update the `GenerateManifestAttributes` target so that `-output-manifest`
    is used to update `manifest-definition.xml`.

The change of the `#endif` required updating lots of source code.
    @jonpryor
    jonpryor committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a88f583 View commit details
    Browse the repository at this point in the history