Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EF components to 9.0 #5207

Open
1 task done
AndriySvyryd opened this issue Aug 7, 2024 · 1 comment · May be fixed by #5932
Open
1 task done

Upgrade EF components to 9.0 #5207

AndriySvyryd opened this issue Aug 7, 2024 · 1 comment · May be fixed by #5932
Assignees
@sebastienros
Labels
area-integrations Issues pertaining to Aspire Integrations packages enhancement An enhancement to an existing feature or capability.
Milestone
9.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 7, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

EF 9.0 introduced engine-specific API for SQL Server, Azure SQL and Azure Synapse. If UseAzureSynapse or UseAzureSql is called by the user in AddDbContext, then EnrichSqlServerDbContext will throw, because it calls UseSqlServer and now that results in conflicting configuration.

EF 9.0 also has a number of significant improvements for migrations scenarios relevant to Aspire.

Describe the solution you'd like

EnrichSqlServerDbContext should call ConfigureSqlEngine with EnableRetryOnFailureByDefault instead of UseSqlServer.

Additionally, it and other EF components should call ConfigureDbContext instead of PatchServiceDescriptor as that depends on implementation details.

Additional context

No response
@AndriySvyryd AndriySvyryd added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 7, 2024
This was referenced Aug 7, 2024
Open
Open
Open
@davidfowl davidfowl modified the milestones: 8.2, 9.0 Sep 7, 2024
@davidfowl davidfowl added the enhancement An enhancement to an existing feature or capability. label Sep 8, 2024
@davidfowl
Copy link
Member

@sebastienros can you take this one?

@sebastienros sebastienros linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastienros sebastienros

Labels
area-integrations Issues pertaining to Aspire Integrations packages enhancement An enhancement to an existing feature or capability.
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Add net9.0 support for EFCore components dotnet/aspire
3 participants
@davidfowl @sebastienros @AndriySvyryd