Add net9.0 support for EFCore components #5932

sebastienros · 2024-09-25T23:22:05Z

Microsoft Reviewers: Open in CodeFlow

global.json

…erator

AndriySvyryd

Not blocking, but for futureproofing also change EnrichNpgsqlDbContext, EnrichMySqlDbContext, EnrichOracleDatabaseDbContext and EnrichCosmosDbContext to use ConfigureDbContext

Consider renaming AspireAzureEFCoreCosmosExtensions

eerhardt · 2024-09-26T13:32:29Z

eng/Versions.props

  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(TargetFramework)' == 'net9.0'">


I don't understand why we need to do this split. Microsoft.EntityFrameworkCore 9.0-rc1 targets net8.0. Why do we need to keep referencing the version 8 packages when targeting net8.0? Why can't we just continue to only target net8.0 and depend on EF v9.0?

I talked about it with @joperezr before starting. efcore 9.0 brings extensions dependencies on 9.0 which we would have to bump (logging, ...), and customers would then need these too, even when targeting 8.0. If we didn't do that users who would like to stay on 9.0 for support reasons would not be able to.

I don't like this situation we are putting people (especially library authors) into.

You can reference the 9.0 extension libraries on net8.0. If we cared about this, we should make EF multi-target and not pull in the 9.0 extensions when on net8.0.

We shouldn't have some teams caring about this, and some teams not.

cc @ericstj @SamMonoRT

Lots of people care about this because it'll mean going from using extensions from the shared framework, to bin deploying all of extensions for .NET 8 apps.

Should we fix EF then? Why does their version 9.0 packages support net8.0 but lift up MS.Ext references to version 9.0?

Im surprised it doesn't

Would this work? dotnet/efcore#34769

Wouldn't it cause downgrade warnings when used in conjunction with other 9.x packages?

…rencing project. We are calling GetTargetPath, and when the referencing project references a different TargetFramework than ConfigurationSchemaGenerator, it is using the referencing projects TargetFramework, which isn't correct.

davidfowl · 2024-09-26T15:31:18Z

Not blocking, but for futureproofing also change EnrichNpgsqlDbContext, EnrichMySqlDbContext, EnrichOracleDatabaseDbContext and EnrichCosmosDbContext to use ConfigureDbContext

We want to use these new APIs as part of these EF upgrade so that we can actually use the new methods and make sure they work in the scenarios they were designed for.

sebastienros · 2024-09-30T18:10:20Z

@radical Please check the build changes. I updated the ZipTestArchive target to handle the multi-target build step which doesn't have OutDir. And also solved a concurrency issue when the two tfms are built in parallel and would write the same file. The non-default TFM is added as a prefix on the zip filename.

radical · 2024-09-30T19:20:53Z

tests/Directory.Build.targets

-    <ZipDirectory SourceDirectory="$(TestsArchiveSourceDir)"
-                  DestinationFile="$([MSBuild]::NormalizePath('$(TestArchiveTestsDir)', '$(MSBuildProjectName).zip'))"
+    <!-- TestsArchiveSourceDir is empty (OutDir) for multi-target build step -->
+    <MakeDir Condition="$(TestsArchiveSourceDir) != ''" Directories="$(TestArchiveTestsDir)" />


If it is empty then how why doesn't ZipDirectory fail with empty SourceDirectory?

oh, you are skipping it in that case. I'll do a local build, and look at the binlog.

It failed before these changes. Now this is skipped when it is the case, when it's invoking the cross-target build.

You can use and '$(IsInnerBuild)' == 'true' in the condition for the target. This will be true when it is doing the inner build - which is one per target framework. And the target will get skipped for the outer build.

Thanks, will try that instead

radical · 2024-09-30T22:54:10Z

tests/Directory.Build.targets

-                  DestinationFile="$([MSBuild]::NormalizePath('$(TestArchiveTestsDir)', '$(MSBuildProjectName).zip'))"
+    <!-- TestsArchiveSourceDir is empty (OutDir) for multi-target build step -->
+    <MakeDir Condition="$(TestsArchiveSourceDir) != ''" Directories="$(TestArchiveTestsDir)" />
+    <ZipDirectory Condition="$(TestsArchiveSourceDir) != '' and '$(TargetFramework)' == '$(DefaultTargetFramework)'"


Also, the '$(TargetFramework)' == '$(DefaultTargetFramework)' means that we would get only the default zip file for net8.0, and not for net9.0.

I could use some help for this one, when I ran helix without this it failed because it would not find a trx file matching the net90.zip file (I rephrased the error message).

Um I can work on that bit.

… trx files

radical · 2024-10-01T08:57:44Z

This needs the workload testing bits to be re-enabled, which would give us a 9.0 sdk with 8.0 runtime to allow running the net9.0 tests here on helix.

This reverts commit c441c00.

This reverts commit 0df93fa.

radical · 2024-10-01T22:32:25Z

The net9.0 tests here will need a 9 sdk to run on helix. We could normally get that from the workload-tests setup, but since that is disabled in the repo right now, and waiting for on #5932 - we can't test it right now.

I hope to have the templates PR merged this week. If this needs to merged sooner, then an alternative would be to get the test infra (just msbuild should be enough) changes here.

# Conflicts: # eng/Versions.props

…ning 9.0 tests also

radical · 2024-10-03T19:52:59Z

net9.0 tests are running succesfully:

Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests-net9.0
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests-net9.0
Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests-net9.0
Aspire.Oracle.EntityFrameworkCore.Tests-net9.0

sebastienros · 2024-10-03T21:47:36Z

I have tested it works locally.

service with net9.0
both AddNpgsqlDbContext and EnrichNpgsqlDbContext
enabling/disabling metrics from code

… from an item

…g the lines on ;

sebastienros · 2024-10-05T16:04:48Z

Two tests failed. One seems to be a random issue with te TestHost.App playground and the fact that RabbitMQ management was assigned the same port as CatalogDb web app.

The second is related to this change, but the tests timed out. Increasing it for now since none show up as a problem.

Add net9.0 support for EFCore components

f38ef80

sebastienros requested review from radical and eerhardt as code owners September 25, 2024 23:22

sebastienros requested review from AndriySvyryd, davidfowl and joperezr September 25, 2024 23:23

sebastienros commented Sep 25, 2024

View reviewed changes

global.json Outdated Show resolved Hide resolved

sebastienros added 2 commits September 25, 2024 18:23

Update Npgsql

dd4203a

Fix GetTargetPath errors when multi-targetting ConfigurationSchemaGen…

443b051

…erator

AndriySvyryd approved these changes Sep 26, 2024

View reviewed changes

eerhardt reviewed Sep 26, 2024

View reviewed changes

sebastienros added 4 commits September 27, 2024 10:47

Merge remote-tracking branch 'origin/main' into sebros/efcore9

5c1a542

Update other ef packages

52e57af

Fix multi-target helix zip generation

2caef9e

Fix Zip file generation in Helix

d7ec8ee

Try to fix helix steps

afaaa6e

radical reviewed Sep 30, 2024

View reviewed changes

build-analysis bot mentioned this pull request Sep 30, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

radical reviewed Sep 30, 2024

View reviewed changes

sebastienros and others added 6 commits September 30, 2024 16:13

Use $(InnerBuild) to skip cross-target builds

d2acb40

Fix archiving the tests

11ddf95

Use the tfm in the path for the archive, and use that to disambiguate…

42788a1

… trx files

Try to fix it a different way

d4c2716

another fix

0804f4a

fix coverage file name

4fdcec2

Merge remote-tracking branch 'origin/main' into sebros/efcore9

06eb57e

radical added 3 commits October 1, 2024 17:59

revert unnecessary changes

c441c00

Revert "revert unnecessary changes"

fd39055

This reverts commit c441c00.

Revert "Use sdk used for testing, to run basictests on helix"

0fdfc78

This reverts commit 0df93fa.

AndriySvyryd mentioned this pull request Oct 2, 2024

[release/9.0] Use 8.x Microsoft.Extensions.* packages dotnet/efcore#34769

Open

sebastienros and others added 5 commits October 2, 2024 18:09

Merge branch 'main' into sebros/efcore9

8e198fd

Merge remote-tracking branch 'origin/main' into sebros/efcore9

618aeea

# Conflicts: # eng/Versions.props

[ci] Use custom sdk to run basictests on helix, which would allow run…

cd1e20a

…ning 9.0 tests also

fix bad merge

4b9a734

And don't use the dotnet cli from arcade

314a1b9

debug failures on helix/windows

0eb42d1

debugging

c8d32dd

build-analysis bot mentioned this pull request Oct 4, 2024

Some tests timing out on helix #5247

Open

radical and others added 14 commits October 4, 2024 12:38

Merge remote-tracking branch 'origin/main' into sebros/efcore9

9df4ddf

revert debugging changes

fcbfc05

Disable code-coverage on windows

0da99dd

Use property for precommands to avoid command line getting split on ;…

221b791

… from an item

fix msbuild

e751119

try to set the path directly in the command to avoid msbuild splittin…

292e511

…g the lines on ;

Merge remote-tracking branch 'origin/main' into sebros/efcore9

bff8149

don't include dotnet-cli from arcade

6f9407c

Add dotnet-tests to path early, so that dotnet dev-certs can work

491730a

re-enable code coverage on windows

c5c6cf8

fix yml

a2c954c

set DOTNET_ROOT

ef15517

fix workload tests

7eb02f8

Increase test timeout for MySql.EF

3a7106a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add net9.0 support for EFCore components #5932

Add net9.0 support for EFCore components #5932

sebastienros commented Sep 25, 2024 •

edited by dotnet-policy-service bot

Loading

AndriySvyryd left a comment

eerhardt Sep 26, 2024

sebastienros Sep 26, 2024

eerhardt Sep 26, 2024

davidfowl Sep 26, 2024

eerhardt Sep 26, 2024 •

edited

Loading

davidfowl Sep 26, 2024

AndriySvyryd Sep 26, 2024

davidfowl commented Sep 26, 2024

sebastienros commented Sep 30, 2024

radical Sep 30, 2024

radical Sep 30, 2024

sebastienros Sep 30, 2024

radical Sep 30, 2024

sebastienros Sep 30, 2024

radical Sep 30, 2024

sebastienros Sep 30, 2024

radical Sep 30, 2024

radical commented Oct 1, 2024

radical commented Oct 1, 2024

radical commented Oct 3, 2024 •

edited

Loading

sebastienros commented Oct 3, 2024

sebastienros commented Oct 5, 2024 •

edited

Loading

		</PropertyGroup>

		<PropertyGroup Condition="'$(TargetFramework)' == 'net9.0'">

Add net9.0 support for EFCore components #5932

Are you sure you want to change the base?

Add net9.0 support for EFCore components #5932

Conversation

sebastienros commented Sep 25, 2024 • edited by dotnet-policy-service bot Loading

Microsoft Reviewers: Open in CodeFlow

AndriySvyryd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eerhardt Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidfowl commented Sep 26, 2024

sebastienros commented Sep 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radical commented Oct 1, 2024

radical commented Oct 1, 2024

radical commented Oct 3, 2024 • edited Loading

sebastienros commented Oct 3, 2024

sebastienros commented Oct 5, 2024 • edited Loading

sebastienros commented Sep 25, 2024 •

edited by dotnet-policy-service bot

Loading

eerhardt Sep 26, 2024 •

edited

Loading

radical commented Oct 3, 2024 •

edited

Loading

sebastienros commented Oct 5, 2024 •

edited

Loading