Extract Aspire.Hosting.NodeJs.Tests project #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-integrations
20 tasks
Open
3 tasks
|
@eerhardt this looks good to me. Although it looks like the test is timing out. |
sebastienros
approved these changes
Aug 5, 2024
sebastienros
reviewed
Aug 5, 2024
| [Fact] | ||
| public async Task VerifyManifest() | ||
| { | ||
| using var builder = TestDistributedApplicationBuilder.Create(); |
There was a problem hiding this comment.
Fine since no Docker image is involved with Node resources.
radical
reviewed
Aug 6, 2024
Extract the main NodeJs tests from Aspire.Hosting.Tests and the end-to-end TestProject. Aspire.Hosting.Tests still uses NodeJs in a few places as an example "Executable" resource. Since NodeJs is just being used as an example - and not testing NodeJs itself, I decided to leave Aspire.Hosting.Tests using it. Also fix an issue with the RequiresTools attribute when the executable isn't an ".exe" extension - like npm is on Windows - it is `npm.cmd`. Contributes to dotnet#4294
eerhardt
force-pushed
the
ExtractNodeJSTests
branch
from
d61fc7a
to
70294a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the main NodeJs tests from Aspire.Hosting.Tests and the end-to-end TestProject.
Aspire.Hosting.Tests still uses NodeJs in a few places as an example "Executable" resource. Since NodeJs is just being used as an example - and not testing NodeJs itself, I decided to leave Aspire.Hosting.Tests using it.
Also fix an issue with the RequiresTools attribute when the executable isn't an ".exe" extension - like npm is on Windows - it is
npm.cmd.Contributes to #4294
Microsoft Reviewers: Open in CodeFlow