Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Aspire.Hosting.AWS.Tests #5281

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Extract Aspire.Hosting.AWS.Tests #5281

merged 6 commits into from
Aug 14, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Aug 13, 2024 •
edited by dotnet-policy-service bot
Loading

Part of #4294

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Aug 13, 2024
@sebastienros sebastienros requested review from radical and eerhardt and removed request for radical August 13, 2024 18:10
@sebastienros sebastienros mentioned this pull request Aug 13, 2024
Closed
20 tasks
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Aug 13, 2024
eerhardt
eerhardt approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions. LGTM

tests/Aspire.Hosting.AWS.Tests/Aspire.Hosting.AWS.Tests.csproj Outdated Show resolved Hide resolved
src/Aspire.Hosting.AWS/Aspire.Hosting.AWS.csproj Show resolved Hide resolved
@sebastienros sebastienros enabled auto-merge (squash) August 13, 2024 23:09
@sebastienros sebastienros merged commit 749b8ca into main Aug 14, 2024
11 checks passed
@sebastienros sebastienros deleted the sebros/extractaws branch August 14, 2024 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@eerhardt eerhardt eerhardt approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastienros @radical @eerhardt