Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to min execute interval test #5701

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 13, 2024

Description

Fixes #5700

I don't know if this fixes the issue, but it adds logging to provide more information.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK enabled auto-merge (squash) September 13, 2024 07:23
@radical
Copy link
Member

radical commented Sep 13, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 13, 2024

Running the pipeline again to pick fixes for the failures seen here.

@JamesNK JamesNK merged commit f2d447f into main Sep 13, 2024
11 checks passed
@JamesNK JamesNK deleted the jamesnk/min-executable-test branch September 13, 2024 11:25
@JamesNK JamesNK mentioned this pull request Sep 15, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests in Aspire.Dashboard.Tests.TelemetryRepositoryTests.LogTests
3 participants