WaitFor for Azure Storage #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
added
area-integrations
15 tasks
mitchdenny
force-pushed
the
mitchdenny/waitfor-azure-storage
branch
from
a79fcfa
to
7d22f6d
Compare
Open
3 tasks
davidfowl
reviewed
Sep 30, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
reviewed
Oct 1, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… using the emulators.
…/dotnet/aspire into mitchdenny/waitfor-azure-storage
davidfowl
reviewed
Oct 2, 2024
davidfowl
approved these changes
Oct 2, 2024
davidfowl
reviewed
Oct 2, 2024
| @@ -1251,14 +1251,31 @@ await notificationService.PublishUpdateAsync(cr.ModelResource, s => s with | |||
| } | |||
| } | |||
|
|
|||
| private async Task CreateExecutableAsync(AppResource er, ILogger resourceLogger, CancellationToken cancellationToken) | |||
| private async Task PublishConnectionStringAvailableEvent(IResource resource, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
Yes we still have resources that depend on it (Postgres/Redis etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
WaitFor(...)support for Azure Storage. This one ended up being a bit more involved than normal because Azure storage is one of the few resources that has a parent resource that does not have a connection string, whereas child resources do.To make this work I've centralized propagation of the
ConnectionStringAvailableEventevents for child resource and removed it from the extension methods for each resource.Fixes #5645
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow