Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add templates for 9.0 #6058
Add templates for 9.0 #6058
Changes from 24 commits
16d1b7b
10d0a5b
bfbfa37
d4c36a6
2acf79c
6074c51
3be33b4
13d1e42
f89a403
f432076
d5642aa
b52cd28
43f69af
c89fc40
b504b3a
9ef8554
b31c32c
18b6bb0
af26f1d
fc17f09
2cfd0b5
c2519c0
0a2fe6f
5579816
9975d3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the package ID contains
9.0
I think we'd want thegroupIdentity
to beAspire.AppHost.9.0
here (and theidentity
aboveAspire.AppHost.CSharp.9.0.net8
)? That means different 9.x versions can be installed side-by-side (the package IDs already have the major.minor AFAICT) and the template engine will group the templates by theirgroupIdentity
for TFM selection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that depends on whether we want major.minor to be SxS. FWIW, we could leave this .9 today, and if we release a 9.1 which we want to be SxS, make that groupid include the minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point, can always defer that decision