Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct Markdown Formatting for File Name in Dependency Injection Basics Doc #42610

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

HEJOK254
Copy link
Contributor

@HEJOK254 HEJOK254 commented Sep 12, 2024

Summary

Seems like there is a missing underscore on line 64 in the file name, which breaks the formatting:

Then add a new C# file named DefaultGreetingService.cs_ and add the following code:

changed to:

Then add a new C# file named _DefaultGreetingService.cs_ and add the following code:

Internal previews

📄 File 🔗 Preview link
docs/core/extensions/dependency-injection-basics.md docs/core/extensions/dependency-injection-basics

@HEJOK254 HEJOK254 requested review from IEvangelist and a team as code owners September 12, 2024 21:26
@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Sep 12, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HEJOK254

This looks great, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) September 13, 2024 14:01
@BillWagner BillWagner merged commit 8a47fc4 into dotnet:main Sep 13, 2024
11 checks passed
@HEJOK254 HEJOK254 deleted the fix-missing-underscore branch September 16, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants