Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflow debug improvements #42673

Merged
merged 2 commits into from
Sep 23, 2024
Merged

StackOverflow debug improvements #42673

merged 2 commits into from
Sep 23, 2024

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Sep 20, 2024

Added some debugging instructions for debugging a StackOverflow on Windows and made some minor improvements to the pre-existing text. Unfortunately the Windows and Linux instructions remain asymmetric because the dump debugging experience for StackOverflow on Windows isn't good (dotnet/diagnostics#4944). In the future we might also want to add instructions for using VSCode on Linux or add more to the lldb debugging instructions but I didn't want to expand the scope too much for now.

Fixes: dotnet/diagnostics#3506


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/debug-stackoverflow.md docs/core/diagnostics/debug-stackoverflow

Added some debugging instructions for debugging a StackOverflow on Windows and made some minor improvements to the pre-existing text. Unfortunately the Windows and Linux instructions remain asymmetric because the dump debugging experience for StackOverflow on Windows isn't good (dotnet/diagnostics#4944). In the future we might also want to add instructions for using VSCode on Linux or add more to the lldb debugging instructions but I didn't want to expand the scope too much for now.
@noahfalk
Copy link
Member Author

@dotnet/dotnet-diag

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions for your consideration

docs/core/diagnostics/debug-stackoverflow.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-stackoverflow.md Outdated Show resolved Hide resolved
Co-authored-by: Tom McDonald <tommcdon@microsoft.com>
@noahfalk
Copy link
Member Author

Done, thanks Tom!

@noahfalk noahfalk enabled auto-merge (squash) September 23, 2024 21:17
@noahfalk noahfalk merged commit c4ba6c5 into dotnet:main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to debug stack overflow errors on Windows
3 participants