Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFI - ROPC work - VB snippets part 1 #42691

Merged
merged 6 commits into from
Sep 24, 2024
Merged

SFI - ROPC work - VB snippets part 1 #42691

merged 6 commits into from
Sep 24, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 24, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested review from BillWagner and a team as code owners September 24, 2024 02:06
@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 24, 2024
BillWagner
BillWagner approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great.

We should try and address a reasonable number of the build issues though.

@gewarren gewarren merged commit 7f6485e into dotnet:main Sep 24, 2024
7 of 8 checks passed
@gewarren gewarren deleted the sfi-ropc-vb-0923 branch September 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @BillWagner @dotnet-bot