Use sql function IsNullable property to determine its nullability, ra…

…ther than always assume it's nullable
dotnet · Mar 4, 2020 · 3963348 · 3963348
1 parent 3b9d4dc
commit 3963348
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/EFCore.Relational/Query/NullabilityBasedSqlProcessingExpressionVisitor.cs b/src/EFCore.Relational/Query/NullabilityBasedSqlProcessingExpressionVisitor.cs
@@ -1015,8 +1015,7 @@ protected override Expression VisitSqlFunction(SqlFunctionExpression sqlFunction
 
             if (sqlFunctionExpression.IsNiladic)
             {
-                // TODO: #18555
-                _nullable = true;
+                _nullable = sqlFunctionExpression.IsNullable;
 
                 return sqlFunctionExpression.Update(instance, sqlFunctionExpression.Arguments);
             }
@@ -1027,8 +1026,7 @@ protected override Expression VisitSqlFunction(SqlFunctionExpression sqlFunction
                 (arguments[i], _) = VisitInternal<SqlExpression>(sqlFunctionExpression.Arguments[i]);
             }
 
-            // TODO: #18555
-            _nullable = true;
+            _nullable = sqlFunctionExpression.IsNullable;
 
             return sqlFunctionExpression.Update(instance, arguments);
         }