Floor the sequence values to long Min and Max (#22938)

fixes #18314
dotnet · Oct 9, 2020 · b382c24 · b382c24
1 parent ec3df8f
commit b382c24
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 3 deletions.
diff --git a/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs b/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs
@@ -392,9 +392,21 @@ private void GetSequences(
     CAST([s].[scale] AS int) AS [scale],
     [s].[is_cycling],
     CAST([s].[increment] AS int) AS [increment],
-    CAST([s].[start_value] AS bigint) AS [start_value],
-    CAST([s].[minimum_value] AS bigint) AS [minimum_value],
-    CAST([s].[maximum_value] AS bigint) AS [maximum_value]
+    CAST(CASE 
+        WHEN [s].[start_value] >  9223372036854775807 THEN  9223372036854775807
+        WHEN [s].[start_value] < -9223372036854775808 THEN -9223372036854775808
+        ELSE [s].[start_value] 
+        END AS bigint) AS start_value,
+    CAST(CASE 
+        WHEN [s].[minimum_value] >  9223372036854775807 THEN  9223372036854775807
+        WHEN [s].[minimum_value] < -9223372036854775808 THEN -9223372036854775808 
+        ELSE [s].[minimum_value] 
+        END AS bigint) AS minimum_value,
+    CAST(CASE 
+        WHEN [s].[maximum_value] >  9223372036854775807 THEN  9223372036854775807
+        WHEN [s].[maximum_value] < -9223372036854775808 THEN -9223372036854775808
+        ELSE [s].[maximum_value] 
+        END AS bigint) AS maximum_value
 FROM [sys].[sequences] AS [s]
 JOIN [sys].[types] AS [t] ON [s].[user_type_id] = [t].[user_type_id]";
 

diff --git a/test/EFCore.SqlServer.FunctionalTests/Scaffolding/SqlServerDatabaseModelFactoryTest.cs b/test/EFCore.SqlServer.FunctionalTests/Scaffolding/SqlServerDatabaseModelFactoryTest.cs
@@ -143,6 +143,38 @@ public void Sequence_min_max_start_values_are_not_null_if_decimal()
 DROP SEQUENCE [NumericSequence];");
         }
 
+        [ConditionalFact]
+        public void Sequence_high_min_max_start_values_are_not_null_if_decimal()
+        {
+            Test(
+                @"
+CREATE SEQUENCE [dbo].[HighDecimalSequence] 
+ AS [numeric](38, 0)
+ START WITH -99999999999999999999999999999999999999
+ INCREMENT BY 1
+ MINVALUE -99999999999999999999999999999999999999
+ MAXVALUE 99999999999999999999999999999999999999
+ CACHE;",
+                Enumerable.Empty<string>(),
+                Enumerable.Empty<string>(),
+                dbModel =>
+                {
+                    Assert.All(
+                        dbModel.Sequences,
+                        s =>
+                        {
+                            Assert.NotNull(s.StartValue);
+                            Assert.Equal(long.MinValue, s.StartValue);
+                            Assert.NotNull(s.MinValue);
+                            Assert.Equal(long.MinValue, s.MinValue);
+                            Assert.NotNull(s.MaxValue);
+                            Assert.Equal(long.MaxValue, s.MaxValue);
+                        });
+                },
+                @"
+DROP SEQUENCE [HighDecimalSequence];");
+        }
+
         [ConditionalFact]
         public void Sequence_using_type_alias()
         {