Cosmos: Improvement to Find/FindAsync

Allow ReadItem optimization when the Partition Key is known and Cosmos Resource Id is provided or Cosmos Resource Id can be generated based on the default generator or a custom generator.

Fixes #17310

src/EFCore.Cosmos/Diagnostics/Internal/CosmosLoggerExtensions.cs

@@ -51,6 +51,28 @@ public static void ExecutingSqlQuery(
                 cosmosSqlQuery.Query);
         }
 
+        public static void ExecutingReadItem(
+            [NotNull] this IDiagnosticsLogger<DbLoggerCategory.Database.Command> diagnosticsLogger,
+            [NotNull] string partitionKey,
+            [NotNull] string resourceId)
+        {
+            var definition = new EventDefinition<string, string, string>(
+                diagnosticsLogger.Options,
+                CoreEventId.ProviderBaseId,
+                LogLevel.Debug,
+                "CoreEventId.ProviderBaseId",
+                level => LoggerMessage.Define<string, string, string>(
+                    level,
+                    CoreEventId.ProviderBaseId,
+                    "Executing Read Item [Partition Key, Resource Id=[{parameters}]]{newLine}{commandText}"));
+
+            definition.Log(
+                diagnosticsLogger,
+                $"{partitionKey}, {resourceId}", 
+                Environment.NewLine,
+                "Read Item");
+        }
+
         private static string FormatParameters(IReadOnlyList<SqlParameter> parameters)
         {
             return parameters.Count == 0

src/EFCore.Cosmos/Extensions/CosmosServiceCollectionExtensions.cs

@@ -14,6 +14,7 @@
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Metadata.Conventions.Infrastructure;
 using Microsoft.EntityFrameworkCore.Query;
+using Microsoft.EntityFrameworkCore.Query.Internal;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Utilities;
 using Microsoft.EntityFrameworkCore.ValueGeneration;

src/EFCore.Cosmos/Metadata/Conventions/StoreKeyConvention.cs

@@ -4,6 +4,7 @@
 using System.Linq;
 using JetBrains.Annotations;
 using Microsoft.EntityFrameworkCore.Cosmos.Metadata.Internal;
+using Microsoft.EntityFrameworkCore.Cosmos.Metadata;
 using Microsoft.EntityFrameworkCore.Cosmos.ValueGeneration.Internal;
 using Microsoft.EntityFrameworkCore.Metadata.Builders;
 using Microsoft.EntityFrameworkCore.Metadata.Conventions.Infrastructure;

src/EFCore.Cosmos/Properties/CosmosStrings.resx

@@ -168,4 +168,13 @@
   <data name="ReverseRequiresOffsetOrLimit" xml:space="preserve">
     <value>Reverse is not supported without Limit or Offset.</value>
   </data>
+  <data name="InvalidResourceId" xml:space="preserve">
+    <value>Invalid Resource id. Resource id cannot be null or empty and must be a string value.</value>
+  </data>
+  <data name="ParitionKeyMissing" xml:space="preserve">
+    <value>Partition key missing.</value>
+  </data>
+  <data name="ResourceIdMissing" xml:space="preserve">
+    <value>Resource id missing or cannot be generated.</value>
+  </data>
 </root>

src/EFCore.Cosmos/Query/Internal/CosmosQueryCompilationContext.cs

@@ -8,7 +8,7 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal
 {
     public class CosmosQueryCompilationContext : QueryCompilationContext
     {
-        public virtual string PartitionKey { get; internal set; }
+        public virtual string PartitionKeyFromExtension { get; internal set; }
 
         public CosmosQueryCompilationContext(
             [NotNull] QueryCompilationContextDependencies dependencies, bool async)

src/EFCore.Cosmos/Query/Internal/CosmosQueryContext.cs

@@ -5,6 +5,7 @@
 using Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal;
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Utilities;
+using Microsoft.EntityFrameworkCore.ValueGeneration;
 
 namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal
 {
@@ -28,6 +29,7 @@ public CosmosQueryContext(
             : base(dependencies)
         {
             Check.NotNull(cosmosClient, nameof(cosmosClient));
+
             CosmosClient = cosmosClient;
         }
 
@@ -38,5 +40,13 @@ public CosmosQueryContext(
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
         public virtual CosmosClientWrapper CosmosClient { get; }
+
+        /// <summary>
+        ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
+        ///     the same compatibility standards as public APIs. It may be changed or removed without notice in
+        ///     any release. You should only use it directly in your code with extreme caution and knowing that
+        ///     doing so can result in application failures when updating to a new Entity Framework Core release.
+        /// </summary>
+        public virtual IValueGeneratorSelector ValueGeneratorSelector { get; }
     }
 }

src/EFCore.Cosmos/Query/Internal/CosmosQueryMetadataExtractingExpressionVisitor.cs

@@ -24,7 +24,7 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
             {
                 var innerQueryable = Visit(methodCallExpression.Arguments[0]);
 
-                _cosmosQueryCompilationContext.PartitionKey = (string)((ConstantExpression)methodCallExpression.Arguments[1]).Value;
+                _cosmosQueryCompilationContext.PartitionKeyFromExtension = (string)((ConstantExpression)methodCallExpression.Arguments[1]).Value;
 
                 return innerQueryable;
             }