Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata: Bring back SqlServerDbFunctionConvention #20182

Closed
smitpatel opened this issue Mar 5, 2020 · 6 comments · Fixed by #21388
Closed

Metadata: Bring back SqlServerDbFunctionConvention #20182

smitpatel opened this issue Mar 5, 2020 · 6 comments · Fixed by #21388
Assignees
@smitpatel
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

To set schema as dbo conventionally.

It was there in 2.2 release. It got removed at some point. Currently query injects dbo when printing.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 6, 2020
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Mar 18, 2020 •
edited
Loading

Depends on #19806 or #9329 for doing it "properly"

Note to implementor: See https://github.com/dotnet/efcore/blob/1644f31e04176a9ab0bd6c968ab00cdb0647a0c2/src/EFCore.SqlServer/Query/Internal/SqlServerQuerySqlGenerator.cs

@smitpatel
Copy link
Member Author

Little more details? 😅

@AndriySvyryd
Copy link
Member

@smitpatel Why do you need more details? Are you planning to poach this?

@smitpatel
Copy link
Member Author

May be. I was thinking just a model finalized convention can populate this on SqlServer, without any side-effects or triggering other conventions.

@AndriySvyryd
Copy link
Member

Ok, you could do it that way for now. But with #19806 or #9329 the value would be available during OnModelBuilding, which is preferable

@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed poachable labels Jun 23, 2020
@smitpatel smitpatel assigned smitpatel and unassigned AndriySvyryd Jun 23, 2020
@smitpatel
Copy link
Member Author

Poached. (hopefully ok).

I went the route to bringing the convention back because this was in 5.0 but the other issues which would make further improvements are in backlog so I thought we want to go this route meanwhile.

smitpatel added a commit that referenced this issue Jun 23, 2020
@smitpatel
Metadata: Bring back SqlServerDbFunctionConvention
f9c5dc6 
Resolve #20182
@smitpatel smitpatel mentioned this issue Jun 23, 2020
Merged
smitpatel added a commit that referenced this issue Jun 23, 2020
@smitpatel
Metadata: Bring back SqlServerDbFunctionConvention
76e3f7f 
Resolve #20182
@smitpatel smitpatel mentioned this issue Jun 23, 2020
Merged
smitpatel added a commit that referenced this issue Jun 23, 2020
@smitpatel
Metadata: Bring back SqlServerDbFunctionConvention (#21388)
2213f95 
Resolve #20182
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Metadata: Bring back SqlServerDbFunctionConvention dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd