-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServer: Translate TimeSpan members #19774
SqlServer: Translate TimeSpan members #19774
Conversation
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerTimeSpanMemberTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerTimeSpanMemberTranslator.cs
Outdated
Show resolved
Hide resolved
…imple array initialization in SqlServerTimeSpanMemberTranslator
…the added property Duration
@@ -148,6 +148,54 @@ public override async Task Byte_array_filter_by_SequenceEqual(bool async) | |||
WHERE ""s"".""Banner5"" = @__byteArrayParam_0"); | |||
} | |||
|
|||
[ConditionalTheory(Skip = "PR #19774")] | |||
public override Task TimeSpan_Hours(bool async) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can use expression-bodied method for all these (even on same line if it fits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done 😉
Why didn't Cosmos fail? Is the whole class skipped there? |
Yes. Cosmos does not implement gearsofwar tests. |
This PR is related to the issue #19632 .
The following translations are enabled:
DATEPART(hour, @timeSpan)
DATEPART(minute, @timeSpan)
DATEPART(second, @timeSpan)
DATEPART(millisecond, @timeSpan)