Cleanup Relational for internal API usage #20398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
changed the title
Part of #15393 Changes: - Suppress DatabaseFacadeDependencies related errors. Optimization which no otherprovider should need. - Suppress errors with DebugView & metadata comparers in relationl model. - Suppress NoopExecutionStrategy in RelationalExecutionStrategyFactory - Suppress FindDeclaredPrimaryKey in MigrationModelDiffer - Suppress errors related to valuefactories and InternalEntityEntry in update pipeline - Suppress errors related to temporary value generator in RelationalValueGeneratorSelector - Move SemanticVersionComparer to Relational - Move DbSetFinderExtensions, DbSetProperty, ConventionAnnotatable, Graph, IndentedStringBuilder to .Infrastructure - Move Multigraph, ReferenceEqualityComparer to shared internal - Remove DbSetProperty.IsKeyless - dead code
|
Updated. |
AndriySvyryd
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15393
Changes:
Suppress DatabaseFacadeDependencies related errors. Optimization which no otherprovider should need.
Suppress errors with DebugView & metadata comparers in relationl model.
Suppress NoopExecutionStrategy in RelationalExecutionStrategyFactory
Suppress FindDeclaredPrimaryKey in MigrationModelDiffer
Suppress errors related to valuefactories and InternalEntityEntry in update pipeline
Suppress errors related to temporary value generator in RelationalValueGeneratorSelector
Move SemanticVersionComparer to Relational
Move DbSetFinderExtensions, DbSetProperty, ConventionAnnotatable, Graph, IndentedStringBuilder to .Infrastructure
Move Multigraph, ReferenceEqualityComparer to shared internal
Remove DbSetProperty.IsKeyless - dead code